Let pipeline and its recipes blur on-screen secrets (OCR scan) in the same call

Offen
#341 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
45/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript

Rechercherichtung

Start with src/tools/pipeline.ts and src/utils/recipes.ts, then read src/cli.ts around redactCopy and src/utils/ocrScan.ts to understand the existing OCR flow. Run npm test to see the project’s current checks. Done means pipeline redaction and recipe options can scan source frames for secrets and turn matches into timed regions, with the CLI logic shared as described; the default behavior for recipes remains an open question.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

effort: medium enhancement priority: high

Summary

The pipeline redact op takes only explicit regions, and the pr_demo / tutorial / social_reel recipes never scan for secrets. The OCR-scan-then-blur flow exists, but only as private CLI code (redactCopy). Making a demo shareable safely therefore takes find_text, then redact_region (a full re-encode), then pipeline.

Where

  • src/tools/pipeline.ts:65-71 (redact op schema)
  • src/utils/recipes.ts:30-60
  • src/cli.ts:591-630 (redactCopy: find_text { scanEverySec, query: DEFAULT_SECRET_PATTERN, regex, redact: true } then redact_region)

Impact

The main "make this shareable" path can publish a token that showed on screen unless the agent remembers a separate two-tool pass, which costs an extra re-encode.

Proposal

Add secrets?: boolean | { pattern?: string } to the pipeline redact op, and a redactSecrets option on recipes, planned as a pre-pass like cut_idle and transcribe (pending probes): run scanVideoFrames + scanMatches on the source and turn the matches into timed redact regions. These are source-coordinate ops, which recipes already place before zoom/reframe (recipes.ts:67). Move redactCopy's logic into a util shared by the CLI, bug_report and pipeline.

Open question: should recipes turn it on by default when OCR is available (matching the consent-by-default stance of #266)?

Getting started

  • Relevant files: src/tools/pipeline.ts, src/utils/recipes.ts, src/cli.ts, src/utils/ocrScan.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: high. Effort: M. audit-key: enhancement|src/tools/pipeline.ts|redact.secrets

Vorherrschende Sprache
TypeScript
Sterne
1
Forks
4
Ø Merge
14 Std. 8 Min.
Gemergte PRs (30 T.)
48

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/screencast-mcp

Alle Issues in TMHSDigital/screencast-mcp

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.