Expanded items under Quick Access collapse when the window regains focus

Offen
  • Stimmt etwas nicht?
#9,235 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
52/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
javascript
Bereich
frontend

Rechercherichtung

Start by tracing the visibilitychange handler in account-panel/dist/panels/AccountPanel/index.js to ensureCorrectSubscriptionNodes in out/app/index.js, then read resetAndRefreshChildren() in explorer-panel. Reproduce the focus change with expanded Quick Access items and check how child view models are rebuilt. Done means expanded descendants remain open after returning to the window, without breaking refreshes after subscription changes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Storage Explorer Version

1.47.1

Regression From

No response

Architecture

x64

Storage Explorer Build Number

20261106.18

Platform

Windows

OS Version

Windows 11

Bug Description

When I switch away from Storage Explorer and come back, everything I expanded under Quick Access collapses. The Quick Access node stays expanded, but the containers and folders inside it close every time the window regains focus. Attached Blob, Queue, Table and File services seem to lose their expanded state in the same way.

Analysis (from the shipped JS bundles)
  • account-panel/dist/panels/AccountPanel/index.js registers: 
    document.addEventListener("visibilitychange", () => {
  const hidden = document.webkitHidden;
  hidden ? Host.executeFunction("StorageExplorer.TopLevelNodes.ensureCorrectSubscriptionNodes") : vm.refresh();
});
  • In out/app/index.js, StorageExplorer.TopLevelNodes.ensureCorrectSubscriptionNodes unconditionally runs
    QuickAccessManager.instance.refreshQuickAccessNode() and ResourceTree.refreshChildren(...) on all attached service nodes.
  • refreshQuickAccessNode() → ResourceTree.refreshChildren(["Azure.QuickAccess"]) + expand(["Azure.QuickAccess"]).
  • In explorer-panel, resetAndRefreshChildren() disposes the child group view model and builds a new one, carrying over only the parent's own isExpanded() state. Descendant expansion state is lost.

So a visibility change that isn't a user action triggers a full rebuild of Quick Access, which loses the user's expansion state.

Suggested fixes
  • Only run ensureCorrectSubscriptionNodes when subscription/account selection actually changed (or only when the user leaves the Account panel, not on window-level visibility changes); and/or
  • Make resetAndRefreshChildren() preserve and restore the expansion state of descendants (e.g. by node UID) after reloading.
Workaround

Locally removing the refreshQuickAccessNode() call from ensureCorrectSubscriptionNodes in out/app/index.js stops the collapse (tested on 1.47.1). This confirms the call is the cause. With that change, Quick Access no longer auto-refreshes after subscription changes.

Resource Types

Quick Access - Storage Accounts

Authentication Method

Sign in

Connection Type

Sign in (subscription)

Steps to Reproduce
  1. Pin a storage account or container to Quick Access.
  2. Expand the item and some of its children (e.g. Blob Containers → a container).
  3. Switch to another application (or minimize Storage Explorer), then return.
Actual Experience

Quick Access stays expanded, but every item underneath it collapses. Attached Blob/Queue/Table/File service nodes appear to lose their child state in the same way.

Expected Experience

The Quick Access tree keeps its expansion state.

Additional Context

No response

Vorherrschende Sprache
Keine Sprachdaten
Sterne
458
Forks
92
Ø Merge
17 Std. 57 Min.
Gemergte PRs (30 T.)
4

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus microsoft/AzureStorageExplorer

Alle Issues in microsoft/AzureStorageExplorer

Ähnliche Issues

Weitere Issues zu Web Dev

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.