Expanded items under Quick Access collapse when the window regains focus

Abierto
  • ¿Algo no está bien?
#9,235 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
52/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
javascript
Área
frontend

Línea de trabajo

Start by tracing the visibilitychange handler in account-panel/dist/panels/AccountPanel/index.js to ensureCorrectSubscriptionNodes in out/app/index.js, then read resetAndRefreshChildren() in explorer-panel. Reproduce the focus change with expanded Quick Access items and check how child view models are rebuilt. Done means expanded descendants remain open after returning to the window, without breaking refreshes after subscription changes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Storage Explorer Version

1.47.1

Regression From

No response

Architecture

x64

Storage Explorer Build Number

20261106.18

Platform

Windows

OS Version

Windows 11

Bug Description

When I switch away from Storage Explorer and come back, everything I expanded under Quick Access collapses. The Quick Access node stays expanded, but the containers and folders inside it close every time the window regains focus. Attached Blob, Queue, Table and File services seem to lose their expanded state in the same way.

Analysis (from the shipped JS bundles)
  • account-panel/dist/panels/AccountPanel/index.js registers: 
    document.addEventListener("visibilitychange", () => {
  const hidden = document.webkitHidden;
  hidden ? Host.executeFunction("StorageExplorer.TopLevelNodes.ensureCorrectSubscriptionNodes") : vm.refresh();
});
  • In out/app/index.js, StorageExplorer.TopLevelNodes.ensureCorrectSubscriptionNodes unconditionally runs
    QuickAccessManager.instance.refreshQuickAccessNode() and ResourceTree.refreshChildren(...) on all attached service nodes.
  • refreshQuickAccessNode() → ResourceTree.refreshChildren(["Azure.QuickAccess"]) + expand(["Azure.QuickAccess"]).
  • In explorer-panel, resetAndRefreshChildren() disposes the child group view model and builds a new one, carrying over only the parent's own isExpanded() state. Descendant expansion state is lost.

So a visibility change that isn't a user action triggers a full rebuild of Quick Access, which loses the user's expansion state.

Suggested fixes
  • Only run ensureCorrectSubscriptionNodes when subscription/account selection actually changed (or only when the user leaves the Account panel, not on window-level visibility changes); and/or
  • Make resetAndRefreshChildren() preserve and restore the expansion state of descendants (e.g. by node UID) after reloading.
Workaround

Locally removing the refreshQuickAccessNode() call from ensureCorrectSubscriptionNodes in out/app/index.js stops the collapse (tested on 1.47.1). This confirms the call is the cause. With that change, Quick Access no longer auto-refreshes after subscription changes.

Resource Types

Quick Access - Storage Accounts

Authentication Method

Sign in

Connection Type

Sign in (subscription)

Steps to Reproduce
  1. Pin a storage account or container to Quick Access.
  2. Expand the item and some of its children (e.g. Blob Containers → a container).
  3. Switch to another application (or minimize Storage Explorer), then return.
Actual Experience

Quick Access stays expanded, but every item underneath it collapses. Attached Blob/Queue/Table/File service nodes appear to lose their child state in the same way.

Expected Experience

The Quick Access tree keeps its expansion state.

Additional Context

No response

Lenguaje dominante
Sin datos de lenguaje
Estrellas
458
Forks
92
Merge medio
17 h 57 min
PR fusionados (30 d)
4

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoft/AzureStorageExplorer

Todos los issues de microsoft/AzureStorageExplorer

Issues similares

Más issues de Web Dev

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.