Resource generation changes committed wrappers during a clean build

Offen
  • Stimmt etwas nicht?
#9,234 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
45/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
node.js, typescript
Bereich
build-system

Rechercherichtung

Read gulp/Resource.template.ts and inspect the buildApp path through @storage-explorer/build-common/gulp/resourceGenerator; compare the generated wrappers under src/Standalone/app/resources with baseline 9a2a48373039fc743ca6eacf6459438c4af8f277. Trace the formatting step and determine why the normal build may not leave these changes. Done means regeneration is stable and the reason for the differing build behavior is established.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Problem

Building Storage Explorer regenerates tracked resource wrappers with a blank line that is absent from the committed files. This makes an otherwise clean checkout dirty and caused orchestrator setup checks to block unrelated bug fixes.

Evidence

  • Observed product baseline: 9a2a48373039fc743ca6eacf6459438c4af8f277.
  • Standalone declares @storage-explorer/build-common ^1.5.0; its lockfile and installed package both resolve to 1.5.0.
  • buildApp runs buildResources, which uses @storage-explorer/build-common/gulp/resourceGenerator and writes to src/Standalone/app/resources.
  • gulp/Resource.template.ts includes a blank line between the missing-resource-manager guard and the return statement in #getResource. The committed versions of 25 wrappers lack that line.
  • Running the generator transforms in memory produced 27 outputs matching the affected worktree files exactly; 25 differ from the committed baseline by one added blank line each. No product build was rerun for this comparison.
  • Current build-common source, version 1.5.5, still contains the blank line. History traces its addition to the March 2025 ESLint migration (0681eb760ac13a01999547a8c0a40c0821352763). Published newer package contents were not verified because registry authentication failed.

Expected behavior

A clean build should leave committed generated wrappers unchanged when their inputs and locked dependencies have not changed.

Requested resolution

Reconcile the committed wrappers and generator/formatting pipeline so regeneration is stable. Determine whether generated files should be refreshed or a subsequent formatting step is inconsistent; do not assume removing the template's blank line is the correct fix. Also establish why the user's normal build does not appear to leave these changes.

Impact

Seven independent orchestrator work items were blocked during setup by identical generated-file changes, before fix implementation. The orchestrator is being adjusted separately to allow recognized generated build outputs while retaining source/test and Git-state protections.

Vorherrschende Sprache
Keine Sprachdaten
Sterne
458
Forks
92
Ø Merge
17 Std. 57 Min.
Gemergte PRs (30 T.)
4

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus microsoft/AzureStorageExplorer

Alle Issues in microsoft/AzureStorageExplorer

Ähnliche Issues

Weitere Issues zu Build System

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.