Expanded items under Quick Access collapse when the window regains focus

Ouverte
  • Quelque chose ne va pas ?
#9,235 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
52/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
javascript
Domaine
frontend

Piste de recherche

Start by tracing the visibilitychange handler in account-panel/dist/panels/AccountPanel/index.js to ensureCorrectSubscriptionNodes in out/app/index.js, then read resetAndRefreshChildren() in explorer-panel. Reproduce the focus change with expanded Quick Access items and check how child view models are rebuilt. Done means expanded descendants remain open after returning to the window, without breaking refreshes after subscription changes.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Storage Explorer Version

1.47.1

Regression From

No response

Architecture

x64

Storage Explorer Build Number

20261106.18

Platform

Windows

OS Version

Windows 11

Bug Description

When I switch away from Storage Explorer and come back, everything I expanded under Quick Access collapses. The Quick Access node stays expanded, but the containers and folders inside it close every time the window regains focus. Attached Blob, Queue, Table and File services seem to lose their expanded state in the same way.

Analysis (from the shipped JS bundles)
  • account-panel/dist/panels/AccountPanel/index.js registers: 
    document.addEventListener("visibilitychange", () => {
  const hidden = document.webkitHidden;
  hidden ? Host.executeFunction("StorageExplorer.TopLevelNodes.ensureCorrectSubscriptionNodes") : vm.refresh();
});
  • In out/app/index.js, StorageExplorer.TopLevelNodes.ensureCorrectSubscriptionNodes unconditionally runs
    QuickAccessManager.instance.refreshQuickAccessNode() and ResourceTree.refreshChildren(...) on all attached service nodes.
  • refreshQuickAccessNode() → ResourceTree.refreshChildren(["Azure.QuickAccess"]) + expand(["Azure.QuickAccess"]).
  • In explorer-panel, resetAndRefreshChildren() disposes the child group view model and builds a new one, carrying over only the parent's own isExpanded() state. Descendant expansion state is lost.

So a visibility change that isn't a user action triggers a full rebuild of Quick Access, which loses the user's expansion state.

Suggested fixes
  • Only run ensureCorrectSubscriptionNodes when subscription/account selection actually changed (or only when the user leaves the Account panel, not on window-level visibility changes); and/or
  • Make resetAndRefreshChildren() preserve and restore the expansion state of descendants (e.g. by node UID) after reloading.
Workaround

Locally removing the refreshQuickAccessNode() call from ensureCorrectSubscriptionNodes in out/app/index.js stops the collapse (tested on 1.47.1). This confirms the call is the cause. With that change, Quick Access no longer auto-refreshes after subscription changes.

Resource Types

Quick Access - Storage Accounts

Authentication Method

Sign in

Connection Type

Sign in (subscription)

Steps to Reproduce
  1. Pin a storage account or container to Quick Access.
  2. Expand the item and some of its children (e.g. Blob Containers → a container).
  3. Switch to another application (or minimize Storage Explorer), then return.
Actual Experience

Quick Access stays expanded, but every item underneath it collapses. Attached Blob/Queue/Table/File service nodes appear to lose their child state in the same way.

Expected Experience

The Quick Access tree keeps its expansion state.

Additional Context

No response

Langage dominant
Aucune donnée de langage
Étoiles
458
Forks
92
Merge moyen
17 h 57 min
PR mergées (30 j)
4

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de microsoft/AzureStorageExplorer

Toutes les issues de microsoft/AzureStorageExplorer

Issues similaires

Plus d'issues Web Dev

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.