Resource generation changes committed wrappers during a clean build

Ouverte
  • Quelque chose ne va pas ?
#9,234 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
45/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
node.js, typescript
Domaine
build-system

Piste de recherche

Read gulp/Resource.template.ts and inspect the buildApp path through @storage-explorer/build-common/gulp/resourceGenerator; compare the generated wrappers under src/Standalone/app/resources with baseline 9a2a48373039fc743ca6eacf6459438c4af8f277. Trace the formatting step and determine why the normal build may not leave these changes. Done means regeneration is stable and the reason for the differing build behavior is established.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Problem

Building Storage Explorer regenerates tracked resource wrappers with a blank line that is absent from the committed files. This makes an otherwise clean checkout dirty and caused orchestrator setup checks to block unrelated bug fixes.

Evidence

  • Observed product baseline: 9a2a48373039fc743ca6eacf6459438c4af8f277.
  • Standalone declares @storage-explorer/build-common ^1.5.0; its lockfile and installed package both resolve to 1.5.0.
  • buildApp runs buildResources, which uses @storage-explorer/build-common/gulp/resourceGenerator and writes to src/Standalone/app/resources.
  • gulp/Resource.template.ts includes a blank line between the missing-resource-manager guard and the return statement in #getResource. The committed versions of 25 wrappers lack that line.
  • Running the generator transforms in memory produced 27 outputs matching the affected worktree files exactly; 25 differ from the committed baseline by one added blank line each. No product build was rerun for this comparison.
  • Current build-common source, version 1.5.5, still contains the blank line. History traces its addition to the March 2025 ESLint migration (0681eb760ac13a01999547a8c0a40c0821352763). Published newer package contents were not verified because registry authentication failed.

Expected behavior

A clean build should leave committed generated wrappers unchanged when their inputs and locked dependencies have not changed.

Requested resolution

Reconcile the committed wrappers and generator/formatting pipeline so regeneration is stable. Determine whether generated files should be refreshed or a subsequent formatting step is inconsistent; do not assume removing the template's blank line is the correct fix. Also establish why the user's normal build does not appear to leave these changes.

Impact

Seven independent orchestrator work items were blocked during setup by identical generated-file changes, before fix implementation. The orchestrator is being adjusted separately to allow recognized generated build outputs while retaining source/test and Git-state protections.

Langage dominant
Aucune donnée de langage
Étoiles
458
Forks
92
Merge moyen
17 h 57 min
PR mergées (30 j)
4

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de microsoft/AzureStorageExplorer

Toutes les issues de microsoft/AzureStorageExplorer

Issues similaires

Plus d'issues Build System

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.