Resource generation changes committed wrappers during a clean build

Abierto
  • ¿Algo no está bien?
#9,234 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
node.js, typescript
Área
build-system

Línea de trabajo

Read gulp/Resource.template.ts and inspect the buildApp path through @storage-explorer/build-common/gulp/resourceGenerator; compare the generated wrappers under src/Standalone/app/resources with baseline 9a2a48373039fc743ca6eacf6459438c4af8f277. Trace the formatting step and determine why the normal build may not leave these changes. Done means regeneration is stable and the reason for the differing build behavior is established.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

Building Storage Explorer regenerates tracked resource wrappers with a blank line that is absent from the committed files. This makes an otherwise clean checkout dirty and caused orchestrator setup checks to block unrelated bug fixes.

Evidence

  • Observed product baseline: 9a2a48373039fc743ca6eacf6459438c4af8f277.
  • Standalone declares @storage-explorer/build-common ^1.5.0; its lockfile and installed package both resolve to 1.5.0.
  • buildApp runs buildResources, which uses @storage-explorer/build-common/gulp/resourceGenerator and writes to src/Standalone/app/resources.
  • gulp/Resource.template.ts includes a blank line between the missing-resource-manager guard and the return statement in #getResource. The committed versions of 25 wrappers lack that line.
  • Running the generator transforms in memory produced 27 outputs matching the affected worktree files exactly; 25 differ from the committed baseline by one added blank line each. No product build was rerun for this comparison.
  • Current build-common source, version 1.5.5, still contains the blank line. History traces its addition to the March 2025 ESLint migration (0681eb760ac13a01999547a8c0a40c0821352763). Published newer package contents were not verified because registry authentication failed.

Expected behavior

A clean build should leave committed generated wrappers unchanged when their inputs and locked dependencies have not changed.

Requested resolution

Reconcile the committed wrappers and generator/formatting pipeline so regeneration is stable. Determine whether generated files should be refreshed or a subsequent formatting step is inconsistent; do not assume removing the template's blank line is the correct fix. Also establish why the user's normal build does not appear to leave these changes.

Impact

Seven independent orchestrator work items were blocked during setup by identical generated-file changes, before fix implementation. The orchestrator is being adjusted separately to allow recognized generated build outputs while retaining source/test and Git-state protections.

Lenguaje dominante
Sin datos de lenguaje
Estrellas
458
Forks
92
Merge medio
17 h 57 min
PR fusionados (30 d)
4

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoft/AzureStorageExplorer

Todos los issues de microsoft/AzureStorageExplorer

Issues similares

Más issues de Build System

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.