Resource generation changes committed wrappers during a clean build

Aperta
  • Qualcosa non va?
#9,234 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
node.js, typescript
Ambito
build-system

Direzione di ricerca

Read gulp/Resource.template.ts and inspect the buildApp path through @storage-explorer/build-common/gulp/resourceGenerator; compare the generated wrappers under src/Standalone/app/resources with baseline 9a2a48373039fc743ca6eacf6459438c4af8f277. Trace the formatting step and determine why the normal build may not leave these changes. Done means regeneration is stable and the reason for the differing build behavior is established.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem

Building Storage Explorer regenerates tracked resource wrappers with a blank line that is absent from the committed files. This makes an otherwise clean checkout dirty and caused orchestrator setup checks to block unrelated bug fixes.

Evidence

  • Observed product baseline: 9a2a48373039fc743ca6eacf6459438c4af8f277.
  • Standalone declares @storage-explorer/build-common ^1.5.0; its lockfile and installed package both resolve to 1.5.0.
  • buildApp runs buildResources, which uses @storage-explorer/build-common/gulp/resourceGenerator and writes to src/Standalone/app/resources.
  • gulp/Resource.template.ts includes a blank line between the missing-resource-manager guard and the return statement in #getResource. The committed versions of 25 wrappers lack that line.
  • Running the generator transforms in memory produced 27 outputs matching the affected worktree files exactly; 25 differ from the committed baseline by one added blank line each. No product build was rerun for this comparison.
  • Current build-common source, version 1.5.5, still contains the blank line. History traces its addition to the March 2025 ESLint migration (0681eb760ac13a01999547a8c0a40c0821352763). Published newer package contents were not verified because registry authentication failed.

Expected behavior

A clean build should leave committed generated wrappers unchanged when their inputs and locked dependencies have not changed.

Requested resolution

Reconcile the committed wrappers and generator/formatting pipeline so regeneration is stable. Determine whether generated files should be refreshed or a subsequent formatting step is inconsistent; do not assume removing the template's blank line is the correct fix. Also establish why the user's normal build does not appear to leave these changes.

Impact

Seven independent orchestrator work items were blocked during setup by identical generated-file changes, before fix implementation. The orchestrator is being adjusted separately to allow recognized generated build outputs while retaining source/test and Git-state protections.

Lingua principale
Nessun dato sulla lingua
Stelle
458
Fork
92
Merge medio
17h 57m
PR unite (30g)
4

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/AzureStorageExplorer

Tutte le issue di microsoft/AzureStorageExplorer

Issue simili

Altre issue su Build System

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.