Fix detection of Construct games
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 45/100
Rechercherichtung
Start from the existing Construct detection rule shown in the issue, especially the package.nw and SDK.NodeJS checks. Review how main files and package.nw archives are searched, then verify detection for c2runtime.js and c3runtime.js at any depth in both locations. Done means the four listed cases identify Construct without relying on the other signals.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
SteamDB link to the game
n/a
What is it being detected as and what should it be detected as? Any other information?
Thanks for your work reviewing engines used on Steam!
Construct comes up as the 5th most popular engine on the engines list, but it looks like the detection merely comes down to this code:
//If I have a package.nw file and it matches nodeJS, it's probably Construct
if( $has( 'Evidence.PACKAGE_NW' ) && $has( 'SDK.NodeJS' ) )
{
return 'Engine.Construct';
}
This won't be accurate: it will produce both false negatives and false positives. In particular not all Construct games even have a file named package.nw - this is optional in Construct.
An accurate way to detect Construct games is to look for a file named either c2runtime.js or c3runtime.js, in the main files (including searching in subfolders) OR inside package.nw (as Construct supports exporting with either packaged or unpackaged assets). The package.nw file is just a zip file, so it can be searched or extracted like any old zip file in order to look for the tell-tale files c2runtime.js/c3runtime.js (which again should include searching in subfolders).
So to be clear there are four cases that indicate a Construct game:
- c2runtime.js anywhere in main files
- c3runtime.js anywhere in main files
- c2runtime.js anywhere inside a zip file named package.nw
- c3runtime.js anywhere inside a zip file named package.nw
You can ignore any other signals, this alone should be reliable enough to identify Construct games. I think implementing this will produce a significantly different number for Construct... but I'm not sure whether it will be higher or lower! It would be interesting to see.
- Vorherrschende Sprache
- PHP
- Sterne
- 234
- Forks
- 112
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus SteamDatabase/FileDetectionRuleSets
-
SQLite OffenType: SDK
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
-
False positive
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
SteamDatabase/FileDetectionRuleSets#928 · 1 Kommentar ·
-
Type: Engine
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 45/100
SteamDatabase/FileDetectionRuleSets#940 · 1 Reaktion ·
-
False negative
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 55/100
-
Messiah Engine OffenType: Engine
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 35/100
Alle Issues in SteamDatabase/FileDetectionRuleSets
Ähnliche Issues
-
tooling
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
-
UX
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
ProfessionalWiki/NeoWiki#1525 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
-
bug customer-reported
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
MagnaCapax/PMSS#949 ·
-
responsive-media kses allow-list strips clipPathUnits, collapsing objectBoundingBox clip paths Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
Automattic/static-site-importer#1829 ·