Fix detection of Construct games
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
Línea de trabajo
Start from the existing Construct detection rule shown in the issue, especially the package.nw and SDK.NodeJS checks. Review how main files and package.nw archives are searched, then verify detection for c2runtime.js and c3runtime.js at any depth in both locations. Done means the four listed cases identify Construct without relying on the other signals.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
SteamDB link to the game
n/a
What is it being detected as and what should it be detected as? Any other information?
Thanks for your work reviewing engines used on Steam!
Construct comes up as the 5th most popular engine on the engines list, but it looks like the detection merely comes down to this code:
//If I have a package.nw file and it matches nodeJS, it's probably Construct
if( $has( 'Evidence.PACKAGE_NW' ) && $has( 'SDK.NodeJS' ) )
{
return 'Engine.Construct';
}
This won't be accurate: it will produce both false negatives and false positives. In particular not all Construct games even have a file named package.nw - this is optional in Construct.
An accurate way to detect Construct games is to look for a file named either c2runtime.js or c3runtime.js, in the main files (including searching in subfolders) OR inside package.nw (as Construct supports exporting with either packaged or unpackaged assets). The package.nw file is just a zip file, so it can be searched or extracted like any old zip file in order to look for the tell-tale files c2runtime.js/c3runtime.js (which again should include searching in subfolders).
So to be clear there are four cases that indicate a Construct game:
- c2runtime.js anywhere in main files
- c3runtime.js anywhere in main files
- c2runtime.js anywhere inside a zip file named package.nw
- c3runtime.js anywhere inside a zip file named package.nw
You can ignore any other signals, this alone should be reliable enough to identify Construct games. I think implementing this will produce a significantly different number for Construct... but I'm not sure whether it will be higher or lower! It would be interesting to see.
- Lenguaje dominante
- PHP
- Estrellas
- 234
- Forks
- 112
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de SteamDatabase/FileDetectionRuleSets
-
SQLite AbiertoType: SDK
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
False positive
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
SteamDatabase/FileDetectionRuleSets#928 · 1 comentario ·
-
Type: Engine
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
SteamDatabase/FileDetectionRuleSets#940 · 1 reacción ·
-
False negative
Dificultad 2/5 1-3 horas Aptitud para principiantes 55/100
-
Messiah Engine AbiertoType: Engine
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
Todos los issues de SteamDatabase/FileDetectionRuleSets
Issues similares
-
tooling
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
UX
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
ProfessionalWiki/NeoWiki#1525 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
OpenConext/OpenConext-engineblock#2122 ·
-
Bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Automattic/safe-publish#594 ·