Fix detection of Construct games
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 45/100
Piste de recherche
Start from the existing Construct detection rule shown in the issue, especially the package.nw and SDK.NodeJS checks. Review how main files and package.nw archives are searched, then verify detection for c2runtime.js and c3runtime.js at any depth in both locations. Done means the four listed cases identify Construct without relying on the other signals.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
SteamDB link to the game
n/a
What is it being detected as and what should it be detected as? Any other information?
Thanks for your work reviewing engines used on Steam!
Construct comes up as the 5th most popular engine on the engines list, but it looks like the detection merely comes down to this code:
//If I have a package.nw file and it matches nodeJS, it's probably Construct
if( $has( 'Evidence.PACKAGE_NW' ) && $has( 'SDK.NodeJS' ) )
{
return 'Engine.Construct';
}
This won't be accurate: it will produce both false negatives and false positives. In particular not all Construct games even have a file named package.nw - this is optional in Construct.
An accurate way to detect Construct games is to look for a file named either c2runtime.js or c3runtime.js, in the main files (including searching in subfolders) OR inside package.nw (as Construct supports exporting with either packaged or unpackaged assets). The package.nw file is just a zip file, so it can be searched or extracted like any old zip file in order to look for the tell-tale files c2runtime.js/c3runtime.js (which again should include searching in subfolders).
So to be clear there are four cases that indicate a Construct game:
- c2runtime.js anywhere in main files
- c3runtime.js anywhere in main files
- c2runtime.js anywhere inside a zip file named package.nw
- c3runtime.js anywhere inside a zip file named package.nw
You can ignore any other signals, this alone should be reliable enough to identify Construct games. I think implementing this will produce a significantly different number for Construct... but I'm not sure whether it will be higher or lower! It would be interesting to see.
- Langage dominant
- PHP
- Étoiles
- 234
- Forks
- 112
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de SteamDatabase/FileDetectionRuleSets
-
SQLite OuverteType: SDK
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
-
False positive
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
SteamDatabase/FileDetectionRuleSets#928 · 1 commentaire ·
-
Type: Engine
Difficulté 4/5 3-5 jours Accessibilité débutants 45/100
SteamDatabase/FileDetectionRuleSets#940 · 1 réaction ·
-
False negative
Difficulté 2/5 1-3 heures Accessibilité débutants 55/100
-
Messiah Engine OuverteType: Engine
Difficulté 3/5 1-2 jours Accessibilité débutants 35/100
Toutes les issues de SteamDatabase/FileDetectionRuleSets
Issues similaires
-
tooling
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
-
UX
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
ProfessionalWiki/NeoWiki#1525 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
-
Difficulté 1/5 Moins d'une heure Accessibilité débutants 90/100
OpenConext/OpenConext-engineblock#2122 ·
-
Bug
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
Automattic/safe-publish#594 ·