Fix detection of Construct games
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 45/100
Direção de pesquisa
Start from the existing Construct detection rule shown in the issue, especially the package.nw and SDK.NodeJS checks. Review how main files and package.nw archives are searched, then verify detection for c2runtime.js and c3runtime.js at any depth in both locations. Done means the four listed cases identify Construct without relying on the other signals.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
SteamDB link to the game
n/a
What is it being detected as and what should it be detected as? Any other information?
Thanks for your work reviewing engines used on Steam!
Construct comes up as the 5th most popular engine on the engines list, but it looks like the detection merely comes down to this code:
//If I have a package.nw file and it matches nodeJS, it's probably Construct
if( $has( 'Evidence.PACKAGE_NW' ) && $has( 'SDK.NodeJS' ) )
{
return 'Engine.Construct';
}
This won't be accurate: it will produce both false negatives and false positives. In particular not all Construct games even have a file named package.nw - this is optional in Construct.
An accurate way to detect Construct games is to look for a file named either c2runtime.js or c3runtime.js, in the main files (including searching in subfolders) OR inside package.nw (as Construct supports exporting with either packaged or unpackaged assets). The package.nw file is just a zip file, so it can be searched or extracted like any old zip file in order to look for the tell-tale files c2runtime.js/c3runtime.js (which again should include searching in subfolders).
So to be clear there are four cases that indicate a Construct game:
- c2runtime.js anywhere in main files
- c3runtime.js anywhere in main files
- c2runtime.js anywhere inside a zip file named package.nw
- c3runtime.js anywhere inside a zip file named package.nw
You can ignore any other signals, this alone should be reliable enough to identify Construct games. I think implementing this will produce a significantly different number for Construct... but I'm not sure whether it will be higher or lower! It would be interesting to see.
- Linguagem predominante
- PHP
- Estrelas
- 234
- Forks
- 112
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de SteamDatabase/FileDetectionRuleSets
-
SQLite AbertaType: SDK
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
-
False positive
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
SteamDatabase/FileDetectionRuleSets#928 · 1 comentário ·
-
Type: Engine
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 45/100
SteamDatabase/FileDetectionRuleSets#940 · 1 reação ·
-
False negative
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 55/100
-
Messiah Engine AbertaType: Engine
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 35/100
Todas as issues de SteamDatabase/FileDetectionRuleSets
Issues semelhantes
-
tooling
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
-
UX
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
ProfessionalWiki/NeoWiki#1525 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 90/100
OpenConext/OpenConext-engineblock#2122 ·
-
Bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
Automattic/safe-publish#594 ·