Fix detection of Construct games
まだ誰も着手していません。
評価
調査の方向性
Start from the existing Construct detection rule shown in the issue, especially the package.nw and SDK.NodeJS checks. Review how main files and package.nw archives are searched, then verify detection for c2runtime.js and c3runtime.js at any depth in both locations. Done means the four listed cases identify Construct without relying on the other signals.
索引モデルが issue の本文から書いたものです。
説明
SteamDB link to the game
n/a
What is it being detected as and what should it be detected as? Any other information?
Thanks for your work reviewing engines used on Steam!
Construct comes up as the 5th most popular engine on the engines list, but it looks like the detection merely comes down to this code:
//If I have a package.nw file and it matches nodeJS, it's probably Construct
if( $has( 'Evidence.PACKAGE_NW' ) && $has( 'SDK.NodeJS' ) )
{
return 'Engine.Construct';
}
This won't be accurate: it will produce both false negatives and false positives. In particular not all Construct games even have a file named package.nw - this is optional in Construct.
An accurate way to detect Construct games is to look for a file named either c2runtime.js or c3runtime.js, in the main files (including searching in subfolders) OR inside package.nw (as Construct supports exporting with either packaged or unpackaged assets). The package.nw file is just a zip file, so it can be searched or extracted like any old zip file in order to look for the tell-tale files c2runtime.js/c3runtime.js (which again should include searching in subfolders).
So to be clear there are four cases that indicate a Construct game:
- c2runtime.js anywhere in main files
- c3runtime.js anywhere in main files
- c2runtime.js anywhere inside a zip file named package.nw
- c3runtime.js anywhere inside a zip file named package.nw
You can ignore any other signals, this alone should be reliable enough to identify Construct games. I think implementing this will produce a significantly different number for Construct... but I'm not sure whether it will be higher or lower! It would be interesting to see.
- 主要言語
- PHP
- スター
- 234
- フォーク
- 112
- PR マージ指標
- 30日以内にマージされた PR はありません
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
SteamDatabase/FileDetectionRuleSets のほかの issue
-
SQLite オープンType: SDK
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
-
False positive
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
SteamDatabase/FileDetectionRuleSets#928 · コメント 1 件 ·
-
Type: Engine
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
SteamDatabase/FileDetectionRuleSets#940 · リアクション 1 件 ·
-
False negative
難易度 2/5 1〜3時間 初心者へのやさしさ 55/100
-
Messiah Engine オープンType: Engine
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
SteamDatabase/FileDetectionRuleSets の issue をすべて見る
似ている issue
-
tooling
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
UX
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
ProfessionalWiki/NeoWiki#1525 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
OpenConext/OpenConext-engineblock#2122 ·
-
Bug
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
Automattic/safe-publish#594 ·