Empty insider FileDate fallback loses the known filing calendar day

Offen
#21 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
49/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
csharp
Bereich
data

Rechercherichtung

Read DataProcessing/QuiverInsiderTradingDataDownloader.cs around lines 119–124 and the QuiverInsiderTrading.Reader and QuiverInsiderTradingUniverse.Reader implementations. Trace how each reader interprets an empty FileDate, then inspect the existing NUnit coverage and add cases for omitted same-day timestamps and genuinely unknown dates. Done means both readers preserve the known upload calendar day while the stated timestamp, transaction date, and legacy-column behavior remains covered.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

priority:P2

Problem

The insider-trading downloader deliberately omits FileDate when its calendar day equals Uploaded, but both readers reconstruct an empty value as the upload day minus one day. Consequently, a known filing day is changed, not merely its intraday precision discarded.

This is already present on master at 7ff2155; it is separate from the explicit-timestamp correction in #17 / #19.

Evidence

  • DataProcessing/QuiverInsiderTradingDataDownloader.cs:119–124 writes an empty field when insiderTrade.FileDate.Date == uploadedDate. Its comment says this preserves the calendar day while dropping intraday precision.
  • QuiverInsiderTrading.Reader uses uploadedDate.AddDays(-1) for that empty field.
  • QuiverInsiderTradingUniverse.Reader likewise uses date.AddDays(-1); universe files are keyed by upload date.
  • Both classes document FileDate as the time the transaction was filed and became publicly available.

For example, a filing at 2026-05-08 09:30:00 uploaded on 2026-05-08 is written with an empty filing-date field. The resulting rows have the following shape:

20260508,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
AAPL R735QTJ8XC9X,AAPL,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,

Parse the first row with an AAPL subscription configuration and the second with the universe reader, using read date 2026-05-08.

Two local NUnit assertions against the base readers reproduce:

Expected FileDate: 2026-05-08 00:00:00
Actual FileDate:   2026-05-07 00:00:00
Failed: 2, Passed: 0, Total: 2

Required outcome

For a filing timestamp omitted because its day matches the upload day, both readers must preserve that known calendar day. Keep Time/EndTime, transaction dates, explicit filing timestamps, and legacy-column support unchanged. Add regression coverage for the downloader/reader contract, including how genuinely unknown filing dates should be represented; the same empty field currently covers both cases.

Suggestion: align the missing-value reconstruction with the writer's omission rule rather than changing explicitly stored timestamps again. Recovering the discarded intraday precision is a separate concern.

Priority P2: the verified impact is limited to filing-date metadata; this does not change the availability timestamps.

Vorherrschende Sprache
C#
Sterne
0
Forks
3
Ø Merge
39 Min.
Gemergte PRs (30 T.)
4

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus QuantConnect/Lean.DataSource.QuiverQuant

Alle Issues in QuantConnect/Lean.DataSource.QuiverQuant

Ähnliche Issues

Weitere Issues zu C#

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.