Empty insider FileDate fallback loses the known filing calendar day
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 49/100
Piste de recherche
Read DataProcessing/QuiverInsiderTradingDataDownloader.cs around lines 119–124 and the QuiverInsiderTrading.Reader and QuiverInsiderTradingUniverse.Reader implementations. Trace how each reader interprets an empty FileDate, then inspect the existing NUnit coverage and add cases for omitted same-day timestamps and genuinely unknown dates. Done means both readers preserve the known upload calendar day while the stated timestamp, transaction date, and legacy-column behavior remains covered.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Problem
The insider-trading downloader deliberately omits FileDate when its calendar day equals Uploaded, but both readers reconstruct an empty value as the upload day minus one day. Consequently, a known filing day is changed, not merely its intraday precision discarded.
This is already present on master at 7ff2155; it is separate from the explicit-timestamp correction in #17 / #19.
Evidence
DataProcessing/QuiverInsiderTradingDataDownloader.cs:119–124writes an empty field wheninsiderTrade.FileDate.Date == uploadedDate. Its comment says this preserves the calendar day while dropping intraday precision.QuiverInsiderTrading.ReaderusesuploadedDate.AddDays(-1)for that empty field.QuiverInsiderTradingUniverse.Readerlikewise usesdate.AddDays(-1); universe files are keyed by upload date.- Both classes document
FileDateas the time the transaction was filed and became publicly available.
For example, a filing at 2026-05-08 09:30:00 uploaded on 2026-05-08 is written with an empty filing-date field. The resulting rows have the following shape:
20260508,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
AAPL R735QTJ8XC9X,AAPL,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
Parse the first row with an AAPL subscription configuration and the second with the universe reader, using read date 2026-05-08.
Two local NUnit assertions against the base readers reproduce:
Expected FileDate: 2026-05-08 00:00:00
Actual FileDate: 2026-05-07 00:00:00
Failed: 2, Passed: 0, Total: 2
Required outcome
For a filing timestamp omitted because its day matches the upload day, both readers must preserve that known calendar day. Keep Time/EndTime, transaction dates, explicit filing timestamps, and legacy-column support unchanged. Add regression coverage for the downloader/reader contract, including how genuinely unknown filing dates should be represented; the same empty field currently covers both cases.
Suggestion: align the missing-value reconstruction with the writer's omission rule rather than changing explicitly stored timestamps again. Recovering the discarded intraday precision is a separate concern.
Priority P2: the verified impact is limited to filing-date metadata; this does not change the availability timestamps.
- Langage dominant
- C#
- Étoiles
- 0
- Forks
- 3
- Merge moyen
- 39 min
- PR mergées (30 j)
- 4
Préparer son environnement
Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de QuantConnect/Lean.DataSource.QuiverQuant
-
priority:P2
Difficulté 2/5 1-3 heures Accessibilité débutants 88/100
-
Insider trading readers subtract a day from explicit FileDate timestampsPeut-être pris @quantconnect-kronos l’a pris aujourd’hui. Ouvertekronos:skip priority:P2
Difficulté 2/5 1-3 heures Accessibilité débutants 90/100
QuantConnect/Lean.DataSource.QuiverQuant#17 · 1 commentaire ·
-
Difficulté 3/5 1-2 jours Accessibilité débutants 72/100
Toutes les issues de QuantConnect/Lean.DataSource.QuiverQuant
Issues similaires
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
openclaw/openclaw-windows-node#2287 · 2 commentaires · 1 réaction ·
Les mainteneurs répondent en général sous 1 jour
-
[LANG] Add support for C# (.cs)Ouverteenhancement good first issue help wanted new-language
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
-
approved area: ui bug
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
Gothic-Unity-Project/Gothic-Unity#533 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
conductor-oss/csharp-sdk#183 ·