Empty insider FileDate fallback loses the known filing calendar day

Ouverte
#21 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
49/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
csharp
Domaine
data

Piste de recherche

Read DataProcessing/QuiverInsiderTradingDataDownloader.cs around lines 119–124 and the QuiverInsiderTrading.Reader and QuiverInsiderTradingUniverse.Reader implementations. Trace how each reader interprets an empty FileDate, then inspect the existing NUnit coverage and add cases for omitted same-day timestamps and genuinely unknown dates. Done means both readers preserve the known upload calendar day while the stated timestamp, transaction date, and legacy-column behavior remains covered.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

priority:P2

Problem

The insider-trading downloader deliberately omits FileDate when its calendar day equals Uploaded, but both readers reconstruct an empty value as the upload day minus one day. Consequently, a known filing day is changed, not merely its intraday precision discarded.

This is already present on master at 7ff2155; it is separate from the explicit-timestamp correction in #17 / #19.

Evidence

  • DataProcessing/QuiverInsiderTradingDataDownloader.cs:119–124 writes an empty field when insiderTrade.FileDate.Date == uploadedDate. Its comment says this preserves the calendar day while dropping intraday precision.
  • QuiverInsiderTrading.Reader uses uploadedDate.AddDays(-1) for that empty field.
  • QuiverInsiderTradingUniverse.Reader likewise uses date.AddDays(-1); universe files are keyed by upload date.
  • Both classes document FileDate as the time the transaction was filed and became publicly available.

For example, a filing at 2026-05-08 09:30:00 uploaded on 2026-05-08 is written with an empty filing-date field. The resulting rows have the following shape:

20260508,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
AAPL R735QTJ8XC9X,AAPL,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,

Parse the first row with an AAPL subscription configuration and the second with the universe reader, using read date 2026-05-08.

Two local NUnit assertions against the base readers reproduce:

Expected FileDate: 2026-05-08 00:00:00
Actual FileDate:   2026-05-07 00:00:00
Failed: 2, Passed: 0, Total: 2

Required outcome

For a filing timestamp omitted because its day matches the upload day, both readers must preserve that known calendar day. Keep Time/EndTime, transaction dates, explicit filing timestamps, and legacy-column support unchanged. Add regression coverage for the downloader/reader contract, including how genuinely unknown filing dates should be represented; the same empty field currently covers both cases.

Suggestion: align the missing-value reconstruction with the writer's omission rule rather than changing explicitly stored timestamps again. Recovering the discarded intraday precision is a separate concern.

Priority P2: the verified impact is limited to filing-date metadata; this does not change the availability timestamps.

Langage dominant
C#
Étoiles
0
Forks
3
Merge moyen
39 min
PR mergées (30 j)
4

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de QuantConnect/Lean.DataSource.QuiverQuant

Toutes les issues de QuantConnect/Lean.DataSource.QuiverQuant

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.