Empty insider FileDate fallback loses the known filing calendar day
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 49/100
Direzione di ricerca
Read DataProcessing/QuiverInsiderTradingDataDownloader.cs around lines 119–124 and the QuiverInsiderTrading.Reader and QuiverInsiderTradingUniverse.Reader implementations. Trace how each reader interprets an empty FileDate, then inspect the existing NUnit coverage and add cases for omitted same-day timestamps and genuinely unknown dates. Done means both readers preserve the known upload calendar day while the stated timestamp, transaction date, and legacy-column behavior remains covered.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
The insider-trading downloader deliberately omits FileDate when its calendar day equals Uploaded, but both readers reconstruct an empty value as the upload day minus one day. Consequently, a known filing day is changed, not merely its intraday precision discarded.
This is already present on master at 7ff2155; it is separate from the explicit-timestamp correction in #17 / #19.
Evidence
DataProcessing/QuiverInsiderTradingDataDownloader.cs:119–124writes an empty field wheninsiderTrade.FileDate.Date == uploadedDate. Its comment says this preserves the calendar day while dropping intraday precision.QuiverInsiderTrading.ReaderusesuploadedDate.AddDays(-1)for that empty field.QuiverInsiderTradingUniverse.Readerlikewise usesdate.AddDays(-1); universe files are keyed by upload date.- Both classes document
FileDateas the time the transaction was filed and became publicly available.
For example, a filing at 2026-05-08 09:30:00 uploaded on 2026-05-08 is written with an empty filing-date field. The resulting rows have the following shape:
20260508,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
AAPL R735QTJ8XC9X,AAPL,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
Parse the first row with an AAPL subscription configuration and the second with the universe reader, using read date 2026-05-08.
Two local NUnit assertions against the base readers reproduce:
Expected FileDate: 2026-05-08 00:00:00
Actual FileDate: 2026-05-07 00:00:00
Failed: 2, Passed: 0, Total: 2
Required outcome
For a filing timestamp omitted because its day matches the upload day, both readers must preserve that known calendar day. Keep Time/EndTime, transaction dates, explicit filing timestamps, and legacy-column support unchanged. Add regression coverage for the downloader/reader contract, including how genuinely unknown filing dates should be represented; the same empty field currently covers both cases.
Suggestion: align the missing-value reconstruction with the writer's omission rule rather than changing explicitly stored timestamps again. Recovering the discarded intraday precision is a separate concern.
Priority P2: the verified impact is limited to filing-date metadata; this does not change the availability timestamps.
- Lingua principale
- C#
- Stelle
- 0
- Fork
- 3
- Merge medio
- 39m
- PR unite (30g)
- 4
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di QuantConnect/Lean.DataSource.QuiverQuant
-
priority:P2
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
-
Insider trading readers subtract a day from explicit FileDate timestampsForse già presa @quantconnect-kronos l’ha presa oggi. Apertakronos:skip priority:P2
Difficoltà 2/5 1-3 ore Idoneità per principianti 90/100
QuantConnect/Lean.DataSource.QuiverQuant#17 · 1 commento ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
Tutte le issue di QuantConnect/Lean.DataSource.QuiverQuant
Issue simili
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
openclaw/openclaw-windows-node#2287 · 2 commenti · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
area:host area:operations type:bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
kind:ux needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
elsa-workflows/elsa-foundation#4742 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement good first issue help wanted new-language
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
-
approved area: ui bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno