Empty insider FileDate fallback loses the known filing calendar day
まだ誰も着手していません。
評価
調査の方向性
Read DataProcessing/QuiverInsiderTradingDataDownloader.cs around lines 119–124 and the QuiverInsiderTrading.Reader and QuiverInsiderTradingUniverse.Reader implementations. Trace how each reader interprets an empty FileDate, then inspect the existing NUnit coverage and add cases for omitted same-day timestamps and genuinely unknown dates. Done means both readers preserve the known upload calendar day while the stated timestamp, transaction date, and legacy-column behavior remains covered.
索引モデルが issue の本文から書いたものです。
説明
Problem
The insider-trading downloader deliberately omits FileDate when its calendar day equals Uploaded, but both readers reconstruct an empty value as the upload day minus one day. Consequently, a known filing day is changed, not merely its intraday precision discarded.
This is already present on master at 7ff2155; it is separate from the explicit-timestamp correction in #17 / #19.
Evidence
DataProcessing/QuiverInsiderTradingDataDownloader.cs:119–124writes an empty field wheninsiderTrade.FileDate.Date == uploadedDate. Its comment says this preserves the calendar day while dropping intraday precision.QuiverInsiderTrading.ReaderusesuploadedDate.AddDays(-1)for that empty field.QuiverInsiderTradingUniverse.Readerlikewise usesdate.AddDays(-1); universe files are keyed by upload date.- Both classes document
FileDateas the time the transaction was filed and became publicly available.
For example, a filing at 2026-05-08 09:30:00 uploaded on 2026-05-08 is written with an empty filing-date field. The resulting rows have the following shape:
20260508,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
AAPL R735QTJ8XC9X,AAPL,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
Parse the first row with an AAPL subscription configuration and the second with the universe reader, using read date 2026-05-08.
Two local NUnit assertions against the base readers reproduce:
Expected FileDate: 2026-05-08 00:00:00
Actual FileDate: 2026-05-07 00:00:00
Failed: 2, Passed: 0, Total: 2
Required outcome
For a filing timestamp omitted because its day matches the upload day, both readers must preserve that known calendar day. Keep Time/EndTime, transaction dates, explicit filing timestamps, and legacy-column support unchanged. Add regression coverage for the downloader/reader contract, including how genuinely unknown filing dates should be represented; the same empty field currently covers both cases.
Suggestion: align the missing-value reconstruction with the writer's omission rule rather than changing explicitly stored timestamps again. Recovering the discarded intraday precision is a separate concern.
Priority P2: the verified impact is limited to filing-date metadata; this does not change the availability timestamps.
- 主要言語
- C#
- スター
- 0
- フォーク
- 3
- 平均マージ
- 39分
- マージ済み PR(30日)
- 4
環境構築
このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
QuantConnect/Lean.DataSource.QuiverQuant のほかの issue
-
priority:P2
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
-
Insider trading readers subtract a day from explicit FileDate timestamps対応中かも @quantconnect-kronos が今日担当しました。 オープンkronos:skip priority:P2
難易度 2/5 1〜3時間 初心者へのやさしさ 90/100
QuantConnect/Lean.DataSource.QuiverQuant#17 · コメント 1 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 72/100
QuantConnect/Lean.DataSource.QuiverQuant の issue をすべて見る
似ている issue
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
openclaw/openclaw-windows-node#2287 · コメント 2 件 · リアクション 1 件 ·
メンテナーはふだん 1 日以内に返信
-
area:host area:operations type:bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
kind:ux needs-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100
elsa-workflows/elsa-foundation#4742 ·
メンテナーはふだん 1 日以内に返信
-
enhancement good first issue help wanted new-language
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
-
approved area: ui bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信