Empty insider FileDate fallback loses the known filing calendar day
還沒有人認領這個 Issue。
評估
研究方向
Read DataProcessing/QuiverInsiderTradingDataDownloader.cs around lines 119–124 and the QuiverInsiderTrading.Reader and QuiverInsiderTradingUniverse.Reader implementations. Trace how each reader interprets an empty FileDate, then inspect the existing NUnit coverage and add cases for omitted same-day timestamps and genuinely unknown dates. Done means both readers preserve the known upload calendar day while the stated timestamp, transaction date, and legacy-column behavior remains covered.
由索引模型根據 Issue 內容生成。
描述
Problem
The insider-trading downloader deliberately omits FileDate when its calendar day equals Uploaded, but both readers reconstruct an empty value as the upload day minus one day. Consequently, a known filing day is changed, not merely its intraday precision discarded.
This is already present on master at 7ff2155; it is separate from the explicit-timestamp correction in #17 / #19.
Evidence
DataProcessing/QuiverInsiderTradingDataDownloader.cs:119–124writes an empty field wheninsiderTrade.FileDate.Date == uploadedDate. Its comment says this preserves the calendar day while dropping intraday precision.QuiverInsiderTrading.ReaderusesuploadedDate.AddDays(-1)for that empty field.QuiverInsiderTradingUniverse.Readerlikewise usesdate.AddDays(-1); universe files are keyed by upload date.- Both classes document
FileDateas the time the transaction was filed and became publicly available.
For example, a filing at 2026-05-08 09:30:00 uploaded on 2026-05-08 is written with an empty filing-date field. The resulting rows have the following shape:
20260508,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
AAPL R735QTJ8XC9X,AAPL,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
Parse the first row with an AAPL subscription configuration and the second with the universe reader, using read date 2026-05-08.
Two local NUnit assertions against the base readers reproduce:
Expected FileDate: 2026-05-08 00:00:00
Actual FileDate: 2026-05-07 00:00:00
Failed: 2, Passed: 0, Total: 2
Required outcome
For a filing timestamp omitted because its day matches the upload day, both readers must preserve that known calendar day. Keep Time/EndTime, transaction dates, explicit filing timestamps, and legacy-column support unchanged. Add regression coverage for the downloader/reader contract, including how genuinely unknown filing dates should be represented; the same empty field currently covers both cases.
Suggestion: align the missing-value reconstruction with the writer's omission rule rather than changing explicitly stored timestamps again. Recovering the discarded intraday precision is a separate concern.
Priority P2: the verified impact is limited to filing-date metadata; this does not change the availability timestamps.
- 主要語言
- C#
- 星號
- 0
- 分支
- 3
- 平均合併
- 39 分鐘
- 30 天內合併 PR
- 4
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
QuantConnect/Lean.DataSource.QuiverQuant 的其他 Issue
-
priority:P2
難度 2/5 1-3 小時 新手友好度 88/100
-
Insider trading readers subtract a day from explicit FileDate timestamps可能已有人在做 @quantconnect-kronos 今天認領。 未關閉kronos:skip priority:P2
難度 2/5 1-3 小時 新手友好度 90/100
QuantConnect/Lean.DataSource.QuiverQuant#17 · 1 則留言 ·
-
難度 3/5 1-2 天 新手友好度 72/100
查看 QuantConnect/Lean.DataSource.QuiverQuant 的全部 Issue
相似的 Issue
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
難度 2/5 1-3 小時 新手友好度 76/100
openclaw/openclaw-windows-node#2287 · 2 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
-
area:host area:operations type:bug
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
kind:ux needs-triage
難度 2/5 1-3 小時 新手友好度 66/100
elsa-workflows/elsa-foundation#4742 ·
維護者通常 1 天內回覆
-
enhancement good first issue help wanted new-language
難度 2/5 1-3 小時 新手友好度 82/100
-
approved area: ui bug
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆