Empty insider FileDate fallback loses the known filing calendar day

未關閉
#21 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
49/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
csharp
領域
data

研究方向

Read DataProcessing/QuiverInsiderTradingDataDownloader.cs around lines 119–124 and the QuiverInsiderTrading.Reader and QuiverInsiderTradingUniverse.Reader implementations. Trace how each reader interprets an empty FileDate, then inspect the existing NUnit coverage and add cases for omitted same-day timestamps and genuinely unknown dates. Done means both readers preserve the known upload calendar day while the stated timestamp, transaction date, and legacy-column behavior remains covered.

由索引模型根據 Issue 內容生成。

描述

priority:P2

Problem

The insider-trading downloader deliberately omits FileDate when its calendar day equals Uploaded, but both readers reconstruct an empty value as the upload day minus one day. Consequently, a known filing day is changed, not merely its intraday precision discarded.

This is already present on master at 7ff2155; it is separate from the explicit-timestamp correction in #17 / #19.

Evidence

  • DataProcessing/QuiverInsiderTradingDataDownloader.cs:119–124 writes an empty field when insiderTrade.FileDate.Date == uploadedDate. Its comment says this preserves the calendar day while dropping intraday precision.
  • QuiverInsiderTrading.Reader uses uploadedDate.AddDays(-1) for that empty field.
  • QuiverInsiderTradingUniverse.Reader likewise uses date.AddDays(-1); universe files are keyed by upload date.
  • Both classes document FileDate as the time the transaction was filed and became publicly available.

For example, a filing at 2026-05-08 09:30:00 uploaded on 2026-05-08 is written with an empty filing-date field. The resulting rows have the following shape:

20260508,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
AAPL R735QTJ8XC9X,AAPL,,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,

Parse the first row with an AAPL subscription configuration and the second with the universe reader, using read date 2026-05-08.

Two local NUnit assertions against the base readers reproduce:

Expected FileDate: 2026-05-08 00:00:00
Actual FileDate:   2026-05-07 00:00:00
Failed: 2, Passed: 0, Total: 2

Required outcome

For a filing timestamp omitted because its day matches the upload day, both readers must preserve that known calendar day. Keep Time/EndTime, transaction dates, explicit filing timestamps, and legacy-column support unchanged. Add regression coverage for the downloader/reader contract, including how genuinely unknown filing dates should be represented; the same empty field currently covers both cases.

Suggestion: align the missing-value reconstruction with the writer's omission rule rather than changing explicitly stored timestamps again. Recovering the discarded intraday precision is a separate concern.

Priority P2: the verified impact is limited to filing-date metadata; this does not change the availability timestamps.

主要語言
C#
星號
0
分支
3
平均合併
39 分鐘
30 天內合併 PR
4

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

QuantConnect/Lean.DataSource.QuiverQuant 的其他 Issue

查看 QuantConnect/Lean.DataSource.QuiverQuant 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。