Follow-ups to config generation reporting in symphony-server
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- prometheus, rust
- Domain
- backend, observability
Research direction
Read issue #75 and the README sections describing config reloads, status.json, and the admin metrics endpoint. The issue lists five deferred edge cases but does not select one or define a change to make. Check whether a specific behavior should be revisited and what outcome is expected before estimating completion.
Written by the indexing model from the issue text.
Description
These are small behaviors left as they are by Report the generation of the config a reload applied in status.json (#75). None of them gives a false appliedGeneration to a writer that reads status.json. Each is here so it can be revisited if someone runs into it.
reloadedAtadvances on a reload that skipped a proxy. So doessymphony_config_reload_time_seconds. This predates generations, and it stays because host-manager falls back to the timestamp on older symphony versions. Consider making it success-only once nothing relies on the old meaning./metrics.jsonand the generation samples describe the process that answered. During an overlapped upgrade the admin endpoint can answer from the outgoing process whilestatus.jsonnames the successor. The snapshot carriespidand the README says to compare it. Nothing ties the two together automatically.- Generation labels map CR to LF.
escapeLabelnormalizes line endings, so tokens that differ only by CR and LF render the same in Prometheus.status.jsonand/metrics.jsonkeep the exact string, and writers use counters or hashes. - Two entries for one port-set where one fails. The port is listed in
failedGenerationeven if the other entry applied and now serves the new generation. host-manager writes one entry per port, so this needs a hand-written config. - A running proxy kept beside a successful split. A config that splits one proxy into two, where only one applies, keeps the old proxy because the skipped entry needs its port. The port that applied is then served by both proxies, so some connections get old routes, and
status.jsonlists it twice. The README documents it. Removing the old proxy would leave the skipped port with nothing serving it.
Review-Deferral: a50f8cd314342795 severity=nit category=documentation
Review-Deferral: a4357533996f8c1b severity=nit category=documentation
Review-Deferral: aca0334a249e0dcb severity=nit category=correctness
Review-Deferral: 14972246fe8b3e0e severity=nit category=correctness
Review-Deferral: 40be5c430fabdc85 severity=minor category=correctness
🤖 Generated by Claude Opus 5.5; posted via @kriszyp.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 11h 49m
- Merged PRs (30d)
- 12
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HarperFast/symphony
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/symphony#91 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
HarperFast/symphony#89 ·
Maintainers usually reply within 1 day
-
Mixed-case SNI forwarded to an older peer during a rolling upgrade can reach its wildcard routeOpen
Difficulty 4/5 3-5 days Newbie friendliness 49/100
HarperFast/symphony#93 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
HarperFast/symphony#92 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
HarperFast/symphony#90 ·
Maintainers usually reply within 1 day
All issues in HarperFast/symphony
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
feature request needs triage
Difficulty 1/5 1-3 hours Newbie friendliness 69/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solidjs/solid-docs#1716 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
thecodacus/pithagoras#380 ·
Maintainers usually reply within 1 day