Mixed-case SNI forwarded to an older peer during a rolling upgrade can reach its wildcard route

Open
#93 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
49/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript

Research direction

Start by tracing the SNI route lookup, failoverIngress forwarding, spilled connection handling, and load query code; the issue does not name files or tests. Reproduce the rolling-upgrade cases with an older peer and mixed-case SNI, then check the reload case with a respelled key in the same metrics group. Done when the issue is either resolved or explicitly accepted for the upgrade window, and the rollout behavior is documented.

Written by the indexing model from the issue text.

Description

During a rolling upgrade to the release with case-insensitive SNI matching, an upgraded node can forward a client's raw ClientHello to a peer's failoverIngress that still runs an older release. The older peer matches the SNI byte for byte, so a mixed-case name (API.example.com) can miss its exact route there and reach a wildcard route instead. The same applies to a spilled connection. The upgraded node chose the peer because of its own lookup of the exact route.

A second effect, in the same window: if both peers serve api.example.com and a reload respells it API.example.com in the same metrics group, the upgraded node keeps the installed spelling and keeps asking for api.example.com in its load query. The older peer now holds the raw key API.example.com, answers -, and spill to it stops. Nothing misroutes.

Both last only until every peer runs the new release. The first needs a client that sends uppercase SNI (browsers never do). Track it so a rollout can either accept it or upgrade failover peers together; close once the fleet is on the release.

Review-Deferral: f7682bdfe0600c53 severity=minor category=correctness
Review-Deferral: 7ce6fa47d6346898 severity=minor category=reliability

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.

Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
11h 49m
Merged PRs (30d)
12

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from HarperFast/symphony

All issues in HarperFast/symphony

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.