A failed stderr write while logging a bad route panics the reload

Open Beginner friendly
#89 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust, typescript
Domain
backend

Research direction

Start in src/router.rs at the eprintln! call near line 630, then check the other diagnostic sites in that file. Replace the route diagnostics with fallible stderr writes or the crate’s existing tracing approach, and confirm a failed stderr write cannot panic route loading in new SymphonyProxy() or updateConfig().

Written by the indexing model from the issue text.

Description

build_route_table reports skipped and failing routes with eprintln! (router.rs:630, and about ten more sites in the file). eprintln! panics when the write to stderr fails, so a full disk or a closed stderr pipe turns a log line into a panic inside new SymphonyProxy() or updateConfig(). The reload that hits a bad route is the one that crashes, instead of isolating that route.

Fix: write these diagnostics with a fallible write (writeln!(std::io::stderr(), …) with the error ignored), or through tracing, which the crate already uses elsewhere.

Found during review of the SNI case-insensitivity change, which adds one more input to the duplicate-route log (routes that differ only in case).

Review-Deferral: 635e97bab7c458e7 severity=minor category=reliability

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.

Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
11h 49m
Merged PRs (30d)
12

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from HarperFast/symphony

All issues in HarperFast/symphony

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.