A failed stderr write while logging a bad route panics the reload
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust, typescript
- Domain
- backend
Research direction
Start in src/router.rs at the eprintln! call near line 630, then check the other diagnostic sites in that file. Replace the route diagnostics with fallible stderr writes or the crate’s existing tracing approach, and confirm a failed stderr write cannot panic route loading in new SymphonyProxy() or updateConfig().
Written by the indexing model from the issue text.
Description
build_route_table reports skipped and failing routes with eprintln! (router.rs:630, and about ten more sites in the file). eprintln! panics when the write to stderr fails, so a full disk or a closed stderr pipe turns a log line into a panic inside new SymphonyProxy() or updateConfig(). The reload that hits a bad route is the one that crashes, instead of isolating that route.
Fix: write these diagnostics with a fallible write (writeln!(std::io::stderr(), …) with the error ignored), or through tracing, which the crate already uses elsewhere.
Found during review of the SNI case-insensitivity change, which adds one more input to the duplicate-route log (routes that differ only in case).
Review-Deferral: 635e97bab7c458e7 severity=minor category=reliability
🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 11h 49m
- Merged PRs (30d)
- 12
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HarperFast/symphony
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/symphony#91 ·
Maintainers usually reply within 1 day
-
Mixed-case SNI forwarded to an older peer during a rolling upgrade can reach its wildcard routeOpen
Difficulty 4/5 3-5 days Newbie friendliness 49/100
HarperFast/symphony#93 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
HarperFast/symphony#92 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
HarperFast/symphony#90 ·
Maintainers usually reply within 1 day
-
Don't route to a restarted upstream until it serves, not just acceptsPossibly taken @kriszyp claimed this 14 days ago. Open
HarperFast/symphony#84 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in HarperFast/symphony
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
feature request needs triage
Difficulty 1/5 1-3 hours Newbie friendliness 69/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solidjs/solid-docs#1716 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
thecodacus/pithagoras#380 ·
Maintainers usually reply within 1 day