ACME Host header with a trailing dot does not match its route
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- networking
Research direction
Read http_proxy.ts around host_header and compare its handling with the trailing-dot trimming in sni.rs. Add the reported case to __test__/http-listener.spec.ts, then run that test. Done when an ACME request with Host: tenant.example.com. reaches the same route as the TLS request for that hostname.
Written by the indexing model from the issue text.
Description
The ClientHello SNI has a trailing dot trimmed before routing (sni.rs:387), but the HTTP listener's Host header does not (http_proxy.rs:207). An ACME http-01 request with Host: tenant.example.com. gets a 404 from proxy_acme, while TLS for the same name reaches its route.
Fix: trim one trailing dot in host_header (or before resolve_with in proxy_acme), and add a case to __test__/http-listener.spec.ts.
Found during review of the SNI case-insensitivity change.
Review-Deferral: b89333f326c4482d severity=nit category=correctness
🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 11h 49m
- Merged PRs (30d)
- 12
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HarperFast/symphony
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
HarperFast/symphony#89 ·
Maintainers usually reply within 1 day
-
Mixed-case SNI forwarded to an older peer during a rolling upgrade can reach its wildcard routeOpen
Difficulty 4/5 3-5 days Newbie friendliness 49/100
HarperFast/symphony#93 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
HarperFast/symphony#92 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
HarperFast/symphony#90 ·
Maintainers usually reply within 1 day
-
Don't route to a restarted upstream until it serves, not just acceptsPossibly taken @kriszyp claimed this 14 days ago. Open
HarperFast/symphony#84 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in HarperFast/symphony
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
feature request needs triage
Difficulty 1/5 1-3 hours Newbie friendliness 69/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solidjs/solid-docs#1716 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
thecodacus/pithagoras#380 ·
Maintainers usually reply within 1 day