Cert carry-forward keeps the previous tenant's upstream when a reload reassigns the route
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
Research direction
Start in router.rs at build_route_table (lines 766–781), where the previous route is carried forward after a certificate build failure. Compare the new spec’s metricsGroup with the previous route’s and follow the existing tombstone behavior for a changed client-certificate policy. Done when a tenant change cannot keep forwarding to the previous upstream while its certificate is building; check the related router tests for this reload path.
Written by the indexing model from the issue text.
Description
When a route's cert fails to build on a reload, build_route_table carries the previous route forward whole, upstreams included (router.rs:766-781). The only gate is that the client-certificate policy is unchanged. So a reload that moves an SNI to another tenant (a new metricsGroup and a new upstream) while its new cert is mid-rotation keeps sending that name's traffic to the previous tenant's upstream, under the new tenant's allowedSources, until the cert builds.
The code comment accepts this cost for a cert rotation, where the upstream is the same tenant's. It is a different trade when ownership changes. Suggested fix: do not carry forward when the spec's metricsGroup differs from the previous route's; tombstone the SNI instead, as a changed client-cert policy already does.
Found during review of the SNI case-insensitivity change, which lets a respelled route (API.example.com for api.example.com) reach this path too.
Review-Deferral: 04da97247dd082dc severity=minor category=security
🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 11h 49m
- Merged PRs (30d)
- 12
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HarperFast/symphony
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/symphony#91 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
HarperFast/symphony#89 ·
Maintainers usually reply within 1 day
-
Mixed-case SNI forwarded to an older peer during a rolling upgrade can reach its wildcard routeOpen
Difficulty 4/5 3-5 days Newbie friendliness 49/100
HarperFast/symphony#93 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
HarperFast/symphony#92 ·
Maintainers usually reply within 1 day
-
Don't route to a restarted upstream until it serves, not just acceptsPossibly taken @kriszyp claimed this 14 days ago. Open
HarperFast/symphony#84 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in HarperFast/symphony
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
feature request needs triage
Difficulty 1/5 1-3 hours Newbie friendliness 69/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solidjs/solid-docs#1716 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
thecodacus/pithagoras#380 ·
Maintainers usually reply within 1 day