Follow-ups to config generation reporting in symphony-server

Abierto
  • ¿Algo no está bien?
#77 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Documentación
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
prometheus, rust
Área
backend, observability

Línea de trabajo

Read issue #75 and the README sections describing config reloads, status.json, and the admin metrics endpoint. The issue lists five deferred edge cases but does not select one or define a change to make. Check whether a specific behavior should be revisited and what outcome is expected before estimating completion.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

These are small behaviors left as they are by Report the generation of the config a reload applied in status.json (#75). None of them gives a false appliedGeneration to a writer that reads status.json. Each is here so it can be revisited if someone runs into it.

  • reloadedAt advances on a reload that skipped a proxy. So does symphony_config_reload_time_seconds. This predates generations, and it stays because host-manager falls back to the timestamp on older symphony versions. Consider making it success-only once nothing relies on the old meaning.
  • /metrics.json and the generation samples describe the process that answered. During an overlapped upgrade the admin endpoint can answer from the outgoing process while status.json names the successor. The snapshot carries pid and the README says to compare it. Nothing ties the two together automatically.
  • Generation labels map CR to LF. escapeLabel normalizes line endings, so tokens that differ only by CR and LF render the same in Prometheus. status.json and /metrics.json keep the exact string, and writers use counters or hashes.
  • Two entries for one port-set where one fails. The port is listed in failedGeneration even if the other entry applied and now serves the new generation. host-manager writes one entry per port, so this needs a hand-written config.
  • A running proxy kept beside a successful split. A config that splits one proxy into two, where only one applies, keeps the old proxy because the skipped entry needs its port. The port that applied is then served by both proxies, so some connections get old routes, and status.json lists it twice. The README documents it. Removing the old proxy would leave the skipped port with nothing serving it.

Review-Deferral: a50f8cd314342795 severity=nit category=documentation
Review-Deferral: a4357533996f8c1b severity=nit category=documentation
Review-Deferral: aca0334a249e0dcb severity=nit category=correctness
Review-Deferral: 14972246fe8b3e0e severity=nit category=correctness
Review-Deferral: 40be5c430fabdc85 severity=minor category=correctness

🤖 Generated by Claude Opus 5.5; posted via @kriszyp.

Lenguaje dominante
Rust
Estrellas
1
Forks
0
Merge medio
19 h 12 min
PR fusionados (30 d)
13

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de HarperFast/symphony

Todos los issues de HarperFast/symphony

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.