EPIC: Classic Support

未关闭
#5,821 12 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
20/100
Issue 类型
功能
描述清晰度
需要澄清
活跃度
停滞
技术栈
cpp
领域
game-dev

调研方向

Start with CONTRIBUTING.md and choose one prerequisite or class-module task; this epic spans game-data parsing, gear and talents, spell ranks, and the SimC addon. The issue points to sc_mage.cpp and engine/player/unique_gear_shadowlands.cpp as examples, and to an older TBC commit for legacy code. Done depends on the chosen task, since this ticket does not define a single completion criterion.

由索引模型根据 Issue 内容生成。

描述

enhancement help wanted

Placeholder ticket meant to encompass the work required to get support for Classic Vanilla and/or TBC support into SimC. There are probably lots of things missing from this, but this is a good starting point for anyone interested. See the contribution file for more information on how to participate.

Base Module Work

The bulk of the work for any SimC expansion is mostly down to implementing each class spell in the class module and then subsequent APL work. In order for this work to even start a few prerequisites would be required.

  • Branch created for the version of the game, i.e. classic or tbc
  • Parsing game data into workable Spell Data (somewhat blocked until blizzard publishes client for TBC). Alternatively you could hard code this like it used to be done. Mage examples can be found here. Original TBC simc commit here.
  • Handling items/character stat integrations. Need to be able to import gear and have it have the correct stats/etc
  • Tier Set Bonus constructs. Need the class modules to be able to implement these
  • Talent tree support, currently this is just a talents=1231233 system that would need to be adjusted
  • Spell rank support (might be fine? but would need checking, including APL support if needed)
  • Special gear/trinket/enchants/consumables support - examples from shadowlands

SimC Client Addon

Depends on the base module being done, but the SimC Addon would also need updated/supported for Classic.

  • Addon loads gear in game via /simc properly

Class Modules

Each class module will need various work to make it usable for simming. Typically there is one or more devs per spec, but that isn't a hard requirement. Each class will need spell, tier set bonuses, APLs, and talent implementations.

  • Druid - N/A
  • Hunter - N/A
  • Mage - N/A
  • Paladin - N/A
  • Priest - @seanpeters86
  • Rogue - N/A
  • Shaman - N/A
  • Warlock - N/A
  • Warrior - N/A

Getting old code working

Note that if you want to get the Original TBC simc commit here working you just need to remove -mtune=pentium-m from the Makefile and then run ./simcraft file=profiles/dedmon max_time=300

主要语言
C++
星标
1.6k
派生
789
平均合并
13 小时 25 分钟
30 天内合并 PR
52

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

simulationcraft/simc 的其他 Issue

查看 simulationcraft/simc 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。