Review of OCaml-derived language features
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- ocaml
- 领域
- compilers
调研方向
Start by reading the feature review and its test checklist in this issue, then inspect the linked test work in #9076 and the individual bug reports #9068–#9073 and #9095. The review checked runtime behavior, diagnostics, formatting, editor tooling and interface generation; tests should cover the listed language features, with regression tests added for each fix.
由索引模型根据 Issue 内容生成。
描述
ReScript inherited a number of language features from OCaml that most code never touches: GADTs, existential types, locally abstract types, polymorphic annotations, functors, recursive and first-class modules, extensible variants, private types, constraint, variance annotations, destructive substitution, module type of and #...t patterns. Several of them had little or no test coverage. This issue tracks a review of these features and the bugs it found.
Method
- Usage: counted each feature in 21 public ReScript repositories (about 550k lines, including rescript-lang.org, rescript-relay, sury, rescript-nodejs and the two large Juspay apps), in the stdlib and in our test suites.
- Behaviour: wrote small programs for each feature and checked what they do at run time, their error messages, the formatter, and editor hover, completion and interface generation.
Findings
Run-time behaviour was correct throughout, including GADTs with @as, @tag and @unboxed, existentials packed with first-class modules, and higher-order and generative functors. Every bug was in diagnostics, the formatter or the editor tooling.
Usage outside our own test fixtures:
| Feature | Use |
|---|---|
| GADTs, locally abstract types | rare (rescript-urql, a few bindings) |
Polymorphic annotations ('a.) |
used in sury |
constraint |
rescript-nodejs (Stream, Net) |
open! |
rescript-lang.org, rescript-pages, rescript-nodejs |
module type of |
include module type of in a .resi (rescript-urql) |
#...t patterns |
rescript-lang.org playground |
| User-defined open types | none; only type exn += |
module rec, with type := / with module := |
none |
| Functors, first-class modules, private types, coercion | common |
None of these is a removal candidate. module rec and with type := / with module := have no uses in the corpus, but the corpus is mostly libraries and misses private application code. module rec is the only way to write mutually recursive modules. with type := / with module := amounts to a few branches in the type checker and parser, so removing it would save little. The remaining features are either used or depend on machinery that stays anyway (for example, exn is itself an open type).
Tests
- Tests for GADTs, existentials, polymorphic fields,
constraint, private and indexed extensible types, destructive substitution and typed first-class modules (#9076); each fix PR adds its own regression tests
Bugs
- #9065
- #9066
- #9067
- #9068
- #9069
- #9070
- #9071
- #9072
- #9073
- #9063 (reported separately)
- #9095 (found while reviewing #9077)
Known limitations of the fixes
- #9084: across files, Find References and rename don't connect a use of an applied functor's member (
StrSet.add) to its declaration in the functor's file; within a file they do. - #9085: an extension declared inside a module whose signature hides it is still offered by completion.
- #9083: a functor whose result is a module type identifier (
(O: Ord): Set => …) hovers without its parameters.
Not bugs, noted
- Refutation cases (
| C => .) can't be written. This came up in #6987 together with empty variants; that issue was closed as stale without a decision. exception Xfollowed by a line starting with(parses asexception X(...), the same newline sensitivity asf\n(a).
- 主要语言
- OCaml
- 星标
- 7.5k
- 派生
- 484
- 平均合并
- 20 小时 19 分钟
- 30 天内合并 PR
- 242
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
rescript-lang/rescript 的其他 Issue
-
Record coercion can construct a private record from outside its module可能已有人在做 @cknitt 今天认领。 未关闭
难度 4/5 1-2 天 新手友好度 52/100
rescript-lang/rescript#9124 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 56/100
rescript-lang/rescript#9123 ·
维护者通常 1 天内回复
-
难度 4/5 1-2 天 新手友好度 55/100
rescript-lang/rescript#9122 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 15/100
rescript-lang/rescript#9109 ·
维护者通常 1 天内回复
-
Formatter: five cases where comments and doc comments are placed wrongly可能已有人在做 @cknitt 于 1 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 35/100
rescript-lang/rescript#9107 ·
维护者通常 1 天内回复
查看 rescript-lang/rescript 的全部 Issue
相似的 Issue
-
[MLIR][TOSA] Assertion in verifyBlockScaledTensorType when a tosa op result type is not a tensor未关闭crash mlir:tosa
难度 2/5 1-3 小时 新手友好度 78/100
llvm/llvm-project#236561 · 1 条评论 ·
维护者通常 1 天内回复
-
A-lexer
难度 2/5 1-3 小时 新手友好度 85/100
oxc-project/oxc#28320 ·
维护者通常 1 天内回复
-
[python] Python library model: str(None) is modelled as an unconstrained string instead of "None"未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:codegen backend:spirv bug direction:input
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复