Review of OCaml-derived language features
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- ocaml
- Ambito
- compilers
Direzione di ricerca
Start by reading the feature review and its test checklist in this issue, then inspect the linked test work in #9076 and the individual bug reports #9068–#9073 and #9095. The review checked runtime behavior, diagnostics, formatting, editor tooling and interface generation; tests should cover the listed language features, with regression tests added for each fix.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
ReScript inherited a number of language features from OCaml that most code never touches: GADTs, existential types, locally abstract types, polymorphic annotations, functors, recursive and first-class modules, extensible variants, private types, constraint, variance annotations, destructive substitution, module type of and #...t patterns. Several of them had little or no test coverage. This issue tracks a review of these features and the bugs it found.
Method
- Usage: counted each feature in 21 public ReScript repositories (about 550k lines, including rescript-lang.org, rescript-relay, sury, rescript-nodejs and the two large Juspay apps), in the stdlib and in our test suites.
- Behaviour: wrote small programs for each feature and checked what they do at run time, their error messages, the formatter, and editor hover, completion and interface generation.
Findings
Run-time behaviour was correct throughout, including GADTs with @as, @tag and @unboxed, existentials packed with first-class modules, and higher-order and generative functors. Every bug was in diagnostics, the formatter or the editor tooling.
Usage outside our own test fixtures:
| Feature | Use |
|---|---|
| GADTs, locally abstract types | rare (rescript-urql, a few bindings) |
Polymorphic annotations ('a.) |
used in sury |
constraint |
rescript-nodejs (Stream, Net) |
open! |
rescript-lang.org, rescript-pages, rescript-nodejs |
module type of |
include module type of in a .resi (rescript-urql) |
#...t patterns |
rescript-lang.org playground |
| User-defined open types | none; only type exn += |
module rec, with type := / with module := |
none |
| Functors, first-class modules, private types, coercion | common |
None of these is a removal candidate. module rec and with type := / with module := have no uses in the corpus, but the corpus is mostly libraries and misses private application code. module rec is the only way to write mutually recursive modules. with type := / with module := amounts to a few branches in the type checker and parser, so removing it would save little. The remaining features are either used or depend on machinery that stays anyway (for example, exn is itself an open type).
Tests
- Tests for GADTs, existentials, polymorphic fields,
constraint, private and indexed extensible types, destructive substitution and typed first-class modules (#9076); each fix PR adds its own regression tests
Bugs
- #9065
- #9066
- #9067
- #9068
- #9069
- #9070
- #9071
- #9072
- #9073
- #9063 (reported separately)
- #9095 (found while reviewing #9077)
Known limitations of the fixes
- #9084: across files, Find References and rename don't connect a use of an applied functor's member (
StrSet.add) to its declaration in the functor's file; within a file they do. - #9085: an extension declared inside a module whose signature hides it is still offered by completion.
- #9083: a functor whose result is a module type identifier (
(O: Ord): Set => …) hovers without its parameters.
Not bugs, noted
- Refutation cases (
| C => .) can't be written. This came up in #6987 together with empty variants; that issue was closed as stale without a decision. exception Xfollowed by a line starting with(parses asexception X(...), the same newline sensitivity asf\n(a).
- Lingua principale
- OCaml
- Stelle
- 7.5k
- Fork
- 484
- Merge medio
- 20h 19m
- PR unite (30g)
- 242
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di rescript-lang/rescript
-
Record coercion can construct a private record from outside its moduleForse già presa @cknitt l’ha presa oggi. Aperta
Difficoltà 4/5 1-2 giorni Idoneità per principianti 52/100
rescript-lang/rescript#9124 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 56/100
rescript-lang/rescript#9123 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 4/5 1-2 giorni Idoneità per principianti 55/100
rescript-lang/rescript#9122 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 15/100
rescript-lang/rescript#9109 ·
I maintainer di solito rispondono entro 1 giorno
-
Formatter: five cases where comments and doc comments are placed wronglyForse già presa @cknitt l’ha presa 1 giorno fa. Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
rescript-lang/rescript#9107 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di rescript-lang/rescript
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
CanadaHonk/porffor#426 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
I maintainer di solito rispondono entro 1 giorno
-
[MLIR][TOSA] Assertion in verifyBlockScaledTensorType when a tosa op result type is not a tensorApertacrash mlir:tosa
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
llvm/llvm-project#236561 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Lexer: Turbopack magic comments are not classifiedForse già presa @Aschenbath l’ha presa oggi. ApertaA-lexer
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
oxc-project/oxc#28320 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
[python] Python library model: str(None) is modelled as an unconstrained string instead of "None"Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno