Review of OCaml-derived language features
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- ocaml
- Área
- compilers
Línea de trabajo
Start by reading the feature review and its test checklist in this issue, then inspect the linked test work in #9076 and the individual bug reports #9068–#9073 and #9095. The review checked runtime behavior, diagnostics, formatting, editor tooling and interface generation; tests should cover the listed language features, with regression tests added for each fix.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
ReScript inherited a number of language features from OCaml that most code never touches: GADTs, existential types, locally abstract types, polymorphic annotations, functors, recursive and first-class modules, extensible variants, private types, constraint, variance annotations, destructive substitution, module type of and #...t patterns. Several of them had little or no test coverage. This issue tracks a review of these features and the bugs it found.
Method
- Usage: counted each feature in 21 public ReScript repositories (about 550k lines, including rescript-lang.org, rescript-relay, sury, rescript-nodejs and the two large Juspay apps), in the stdlib and in our test suites.
- Behaviour: wrote small programs for each feature and checked what they do at run time, their error messages, the formatter, and editor hover, completion and interface generation.
Findings
Run-time behaviour was correct throughout, including GADTs with @as, @tag and @unboxed, existentials packed with first-class modules, and higher-order and generative functors. Every bug was in diagnostics, the formatter or the editor tooling.
Usage outside our own test fixtures:
| Feature | Use |
|---|---|
| GADTs, locally abstract types | rare (rescript-urql, a few bindings) |
Polymorphic annotations ('a.) |
used in sury |
constraint |
rescript-nodejs (Stream, Net) |
open! |
rescript-lang.org, rescript-pages, rescript-nodejs |
module type of |
include module type of in a .resi (rescript-urql) |
#...t patterns |
rescript-lang.org playground |
| User-defined open types | none; only type exn += |
module rec, with type := / with module := |
none |
| Functors, first-class modules, private types, coercion | common |
None of these is a removal candidate. module rec and with type := / with module := have no uses in the corpus, but the corpus is mostly libraries and misses private application code. module rec is the only way to write mutually recursive modules. with type := / with module := amounts to a few branches in the type checker and parser, so removing it would save little. The remaining features are either used or depend on machinery that stays anyway (for example, exn is itself an open type).
Tests
- Tests for GADTs, existentials, polymorphic fields,
constraint, private and indexed extensible types, destructive substitution and typed first-class modules (#9076); each fix PR adds its own regression tests
Bugs
- #9065
- #9066
- #9067
- #9068
- #9069
- #9070
- #9071
- #9072
- #9073
- #9063 (reported separately)
- #9095 (found while reviewing #9077)
Known limitations of the fixes
- #9084: across files, Find References and rename don't connect a use of an applied functor's member (
StrSet.add) to its declaration in the functor's file; within a file they do. - #9085: an extension declared inside a module whose signature hides it is still offered by completion.
- #9083: a functor whose result is a module type identifier (
(O: Ord): Set => …) hovers without its parameters.
Not bugs, noted
- Refutation cases (
| C => .) can't be written. This came up in #6987 together with empty variants; that issue was closed as stale without a decision. exception Xfollowed by a line starting with(parses asexception X(...), the same newline sensitivity asf\n(a).
- Lenguaje dominante
- OCaml
- Estrellas
- 7.5k
- Forks
- 484
- Merge medio
- 20 h 19 min
- PR fusionados (30 d)
- 242
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de rescript-lang/rescript
-
Record coercion can construct a private record from outside its modulePosiblemente ocupada @cknitt la tomó hoy. Abierto
Dificultad 4/5 1-2 días Aptitud para principiantes 52/100
rescript-lang/rescript#9124 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 3/5 1-2 días Aptitud para principiantes 56/100
rescript-lang/rescript#9123 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 1-2 días Aptitud para principiantes 55/100
rescript-lang/rescript#9122 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 15/100
rescript-lang/rescript#9109 ·
Los mantenedores suelen responder en 1 día
-
Formatter: five cases where comments and doc comments are placed wronglyPosiblemente ocupada @cknitt la tomó hace 1 día. Abierto
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
rescript-lang/rescript#9107 ·
Los mantenedores suelen responder en 1 día
Todos los issues de rescript-lang/rescript
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
CanadaHonk/porffor#426 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
compiler-rt:asan llvm:transforms
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
llvm/llvm-project#236682 ·
Los mantenedores suelen responder en 1 día
-
Lexer: Turbopack magic comments are not classifiedPosiblemente ocupada @Aschenbath la tomó hoy. AbiertoA-lexer
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
oxc-project/oxc#28320 · 1 comentario ·
Los mantenedores suelen responder en 1 día