Review of OCaml-derived language features
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 35/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- ocaml
- 領域
- compilers
研究方向
Start by reading the feature review and its test checklist in this issue, then inspect the linked test work in #9076 and the individual bug reports #9068–#9073 and #9095. The review checked runtime behavior, diagnostics, formatting, editor tooling and interface generation; tests should cover the listed language features, with regression tests added for each fix.
由索引模型根據 Issue 內容生成。
描述
ReScript inherited a number of language features from OCaml that most code never touches: GADTs, existential types, locally abstract types, polymorphic annotations, functors, recursive and first-class modules, extensible variants, private types, constraint, variance annotations, destructive substitution, module type of and #...t patterns. Several of them had little or no test coverage. This issue tracks a review of these features and the bugs it found.
Method
- Usage: counted each feature in 21 public ReScript repositories (about 550k lines, including rescript-lang.org, rescript-relay, sury, rescript-nodejs and the two large Juspay apps), in the stdlib and in our test suites.
- Behaviour: wrote small programs for each feature and checked what they do at run time, their error messages, the formatter, and editor hover, completion and interface generation.
Findings
Run-time behaviour was correct throughout, including GADTs with @as, @tag and @unboxed, existentials packed with first-class modules, and higher-order and generative functors. Every bug was in diagnostics, the formatter or the editor tooling.
Usage outside our own test fixtures:
| Feature | Use |
|---|---|
| GADTs, locally abstract types | rare (rescript-urql, a few bindings) |
Polymorphic annotations ('a.) |
used in sury |
constraint |
rescript-nodejs (Stream, Net) |
open! |
rescript-lang.org, rescript-pages, rescript-nodejs |
module type of |
include module type of in a .resi (rescript-urql) |
#...t patterns |
rescript-lang.org playground |
| User-defined open types | none; only type exn += |
module rec, with type := / with module := |
none |
| Functors, first-class modules, private types, coercion | common |
None of these is a removal candidate. module rec and with type := / with module := have no uses in the corpus, but the corpus is mostly libraries and misses private application code. module rec is the only way to write mutually recursive modules. with type := / with module := amounts to a few branches in the type checker and parser, so removing it would save little. The remaining features are either used or depend on machinery that stays anyway (for example, exn is itself an open type).
Tests
- Tests for GADTs, existentials, polymorphic fields,
constraint, private and indexed extensible types, destructive substitution and typed first-class modules (#9076); each fix PR adds its own regression tests
Bugs
- #9065
- #9066
- #9067
- #9068
- #9069
- #9070
- #9071
- #9072
- #9073
- #9063 (reported separately)
- #9095 (found while reviewing #9077)
Known limitations of the fixes
- #9084: across files, Find References and rename don't connect a use of an applied functor's member (
StrSet.add) to its declaration in the functor's file; within a file they do. - #9085: an extension declared inside a module whose signature hides it is still offered by completion.
- #9083: a functor whose result is a module type identifier (
(O: Ord): Set => …) hovers without its parameters.
Not bugs, noted
- Refutation cases (
| C => .) can't be written. This came up in #6987 together with empty variants; that issue was closed as stale without a decision. exception Xfollowed by a line starting with(parses asexception X(...), the same newline sensitivity asf\n(a).
- 主要語言
- OCaml
- 星號
- 7.5k
- 分支
- 484
- 平均合併
- 20 小時 19 分鐘
- 30 天內合併 PR
- 242
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
rescript-lang/rescript 的其他 Issue
-
Record coercion can construct a private record from outside its module可能已有人在做 @cknitt 於 1 天前認領。 未關閉
難度 4/5 1-2 天 新手友好度 52/100
rescript-lang/rescript#9124 ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 56/100
rescript-lang/rescript#9123 ·
維護者通常 1 天內回覆
-
難度 4/5 1-2 天 新手友好度 55/100
rescript-lang/rescript#9122 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 15/100
rescript-lang/rescript#9109 ·
維護者通常 1 天內回覆
-
Formatter: five cases where comments and doc comments are placed wrongly可能已有人在做 @cknitt 於 1 天前認領。 未關閉
難度 4/5 3-5 天 新手友好度 35/100
rescript-lang/rescript#9107 ·
維護者通常 1 天內回覆
查看 rescript-lang/rescript 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
CanadaHonk/porffor#426 ·
-
難度 2/5 1-3 小時 新手友好度 77/100
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
compiler-rt:asan llvm:transforms
難度 2/5 1-3 小時 新手友好度 72/100
llvm/llvm-project#236682 ·
維護者通常 1 天內回覆
-
Lexer: Turbopack magic comments are not classified可能已有人在做 @Aschenbath 今天認領。 未關閉A-lexer
難度 2/5 1-3 小時 新手友好度 85/100
oxc-project/oxc#28320 · 1 則留言 ·
維護者通常 1 天內回覆