Review of OCaml-derived language features
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- ocaml
- 領域
- compilers
調査の方向性
Start by reading the feature review and its test checklist in this issue, then inspect the linked test work in #9076 and the individual bug reports #9068–#9073 and #9095. The review checked runtime behavior, diagnostics, formatting, editor tooling and interface generation; tests should cover the listed language features, with regression tests added for each fix.
索引モデルが issue の本文から書いたものです。
説明
ReScript inherited a number of language features from OCaml that most code never touches: GADTs, existential types, locally abstract types, polymorphic annotations, functors, recursive and first-class modules, extensible variants, private types, constraint, variance annotations, destructive substitution, module type of and #...t patterns. Several of them had little or no test coverage. This issue tracks a review of these features and the bugs it found.
Method
- Usage: counted each feature in 21 public ReScript repositories (about 550k lines, including rescript-lang.org, rescript-relay, sury, rescript-nodejs and the two large Juspay apps), in the stdlib and in our test suites.
- Behaviour: wrote small programs for each feature and checked what they do at run time, their error messages, the formatter, and editor hover, completion and interface generation.
Findings
Run-time behaviour was correct throughout, including GADTs with @as, @tag and @unboxed, existentials packed with first-class modules, and higher-order and generative functors. Every bug was in diagnostics, the formatter or the editor tooling.
Usage outside our own test fixtures:
| Feature | Use |
|---|---|
| GADTs, locally abstract types | rare (rescript-urql, a few bindings) |
Polymorphic annotations ('a.) |
used in sury |
constraint |
rescript-nodejs (Stream, Net) |
open! |
rescript-lang.org, rescript-pages, rescript-nodejs |
module type of |
include module type of in a .resi (rescript-urql) |
#...t patterns |
rescript-lang.org playground |
| User-defined open types | none; only type exn += |
module rec, with type := / with module := |
none |
| Functors, first-class modules, private types, coercion | common |
None of these is a removal candidate. module rec and with type := / with module := have no uses in the corpus, but the corpus is mostly libraries and misses private application code. module rec is the only way to write mutually recursive modules. with type := / with module := amounts to a few branches in the type checker and parser, so removing it would save little. The remaining features are either used or depend on machinery that stays anyway (for example, exn is itself an open type).
Tests
- Tests for GADTs, existentials, polymorphic fields,
constraint, private and indexed extensible types, destructive substitution and typed first-class modules (#9076); each fix PR adds its own regression tests
Bugs
- #9065
- #9066
- #9067
- #9068
- #9069
- #9070
- #9071
- #9072
- #9073
- #9063 (reported separately)
- #9095 (found while reviewing #9077)
Known limitations of the fixes
- #9084: across files, Find References and rename don't connect a use of an applied functor's member (
StrSet.add) to its declaration in the functor's file; within a file they do. - #9085: an extension declared inside a module whose signature hides it is still offered by completion.
- #9083: a functor whose result is a module type identifier (
(O: Ord): Set => …) hovers without its parameters.
Not bugs, noted
- Refutation cases (
| C => .) can't be written. This came up in #6987 together with empty variants; that issue was closed as stale without a decision. exception Xfollowed by a line starting with(parses asexception X(...), the same newline sensitivity asf\n(a).
- 主要言語
- OCaml
- スター
- 7.5k
- フォーク
- 484
- 平均マージ
- 20時間 43分
- マージ済み PR（30日）
- 263
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
rescript-lang/rescript のほかの issue
-
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
rescript-lang/rescript#9139 ·
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
rescript-lang/rescript#9151 ·
メンテナーはふだん 1 日以内に返信
-
Printed @as names of fields and constructors turn non-ASCII letters into other characters対応中かも @cknitt が 1 日前に担当しました。 オープン
難易度 4/5 3〜5日 初心者へのやさしさ 25/100
rescript-lang/rescript#9142 ·
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
rescript-lang/rescript#9130 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 1〜2日 初心者へのやさしさ 55/100
rescript-lang/rescript#9122 ·
メンテナーはふだん 1 日以内に返信
rescript-lang/rescript の issue をすべて見る
似ている issue
-
bot-triaged module: inductor oncall: pt2 topic: fuzzer triaged
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信
-
bug needs-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
microsoft/DirectXShaderCompiler#9087 ·
メンテナーはふだん 1 日以内に返信
-
confirmed generated by fuzzer llvm:codegen miscompilation
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
llvm/llvm-project#237380 ·
メンテナーはふだん 1 日以内に返信
-
area:observer area:trace-tape found-by:code-review kind:docs-drift
難易度 2/5 1〜3時間 初心者へのやさしさ 85/100
InauguralSystems/EigenScript#2212 ·
メンテナーはふだん 1 日以内に返信
-
bug medium priority openmp tokenizer wrong result
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信