Tearsheet layout updates: Masthead coverage and inset token alignment
维护者通常 4 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- typescript
调研方向
Start by reviewing the Tearsheet component group and the referenced original PR, then inspect how masthead coverage and the current 4rem inset are implemented. Compare the layout logic with --pf-t--global--spacer--inset--page-chrome and determine the configuration needed for masthead visibility. Done means both masthead behavior and page-chrome alignment match the proposed requirements.
由索引模型根据 Issue 内容生成。
描述
Following design demos and PR feedback, two layout refinements were identified for the Tearsheet component group to maximize vertical screen space and fix horizontal edge alignment with page chrome.
Proposed Updates:
- Masthead Coverage Support
-
Problem: Tearsheets currently display below the masthead, limiting available vertical space compared to large modals.
-
Solution: Allow tearsheets to overlap/cover the masthead area by default or via configuration.
-
Prop Idea: Introduce a prop like coverMasthead (boolean) or showMasthead (boolean) so consumers can toggle masthead visibility based on workflow needs.
- Page Chrome Inset Alignment
-
Problem: The current 4rem (32px) inset creates an ~8px mismatch against standard page chrome (24px inset via --pf-t--global--spacer--inset--page-chrome), causing a sliver of the underlying page container to show along the right edge.
-
Solution: Update width and max-width CSS logic to leverage the design token rather than hardcoded rem values.
-
context from @mcoker's comment from the original PR:
Just an observation (non-blocking IMO) is that the tearsheet inset is about 8px more than our default page chrome/layout inset, so you can see a small bit of the page container behind/along the right edge of the tearsheet.
This is due to the 4rem inset of the tearsheet creating a 32px (2rem) gap on either side, where the page container behind it uses a 24px inset (comes from --pf-t--global--spacer--inset--page-chrome). I imagine the fix would be something like changing the width/max-width to use calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 4) for stack 0, and calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 2) for stack 1. Though if you do that, it's worth noting you should import the tglobalspacerinsetpage*chrome @react-tokens token for the token var instead of hardcoding it.
@GAUNSD @thatblindgeye
Jira Issue: PF-4685
- 主要语言
- TypeScript
- 星标
- 10
- 派生
- 40
- 平均合并
- 3 天 22 小时
- 30 天内合并 PR
- 4
环境准备
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
patternfly/react-component-groups 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
patternfly/react-component-groups#968 · 1 条评论 ·
维护者通常 4 天内回复
-
Pull in Modal animation support for Tearsheets可能已有人在做 @thatblindgeye 于 9 天前认领。 未关闭PF Team
patternfly/react-component-groups#979 · 已指派 1 人 ·
维护者通常 4 天内回复
-
难度 3/5 1-2 天 新手友好度 68/100
patternfly/react-component-groups#969 ·
维护者通常 4 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
patternfly/react-component-groups#942 · 1 条评论 ·
维护者通常 4 天内回复
-
rehor-ai-patternfly
难度 2/5 1-3 小时 新手友好度 58/100
patternfly/react-component-groups#909 · 1 条评论 ·
维护者通常 4 天内回复
查看 patternfly/react-component-groups 的全部 Issue
相似的 Issue
-
ADD openalgo未关闭template
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
factory-active factory-automatic task-bug-reproduction-success task-identify-harness-labels-done task-identify-issue-type-done
难度 2/5 1-3 小时 新手友好度 90/100
维护者通常 1 天内回复
-
bug Needs: Triage :mag:
难度 2/5 1-3 小时 新手友好度 84/100
microsoft/fluentui-contrib#671 ·
-
难度 2/5 1-3 小时 新手友好度 88/100
sveltejs/acorn-typescript#150 ·
-
难度 2/5 1-3 小时 新手友好度 78/100