Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Tearsheet layout updates: Masthead coverage and inset token alignment

Aberta
  • Algo errado?
#985 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 4 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
typescript
Domínio
design, frontend

Direção de pesquisa

Start by reviewing the Tearsheet component group and the referenced original PR, then inspect how masthead coverage and the current 4rem inset are implemented. Compare the layout logic with --pf-t--global--spacer--inset--page-chrome and determine the configuration needed for masthead visibility. Done means both masthead behavior and page-chrome alignment match the proposed requirements.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

PF Team

Following design demos and PR feedback, two layout refinements were identified for the Tearsheet component group to maximize vertical screen space and fix horizontal edge alignment with page chrome.

Proposed Updates:

  1. Masthead Coverage Support

  • Problem: Tearsheets currently display below the masthead, limiting available vertical space compared to large modals.

  • Solution: Allow tearsheets to overlap/cover the masthead area by default or via configuration.

  • Prop Idea: Introduce a prop like coverMasthead (boolean) or showMasthead (boolean) so consumers can toggle masthead visibility based on workflow needs.

  1. Page Chrome Inset Alignment

  • Problem: The current 4rem (32px) inset creates an ~8px mismatch against standard page chrome (24px inset via --pf-t--global--spacer--inset--page-chrome), causing a sliver of the underlying page container to show along the right edge.

  • Solution: Update width and max-width CSS logic to leverage the design token rather than hardcoded rem values.

  • context from @mcoker's comment from the original PR:

    Just an observation (non-blocking IMO) is that the tearsheet inset is about 8px more than our default page chrome/layout inset, so you can see a small bit of the page container behind/along the right edge of the tearsheet.
    This is due to the 4rem inset of the tearsheet creating a 32px (2rem) gap on either side, where the page container behind it uses a 24px inset (comes from --pf-t--global--spacer--inset--page-chrome). I imagine the fix would be something like changing the width/max-width to use calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 4) for stack 0, and calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 2) for stack 1. Though if you do that, it's worth noting you should import the tglobalspacerinsetpage*chrome @react-tokens token for the token var instead of hardcoding it.

@GAUNSD @thatblindgeye

Jira Issue: PF-4685

Linguagem predominante
TypeScript
Estrelas
10
Forks
40
Merge médio
3d 22h
PRs com merge (30d)
4

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de patternfly/react-component-groups

Todas as issues de patternfly/react-component-groups

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.