Tearsheet layout updates: Masthead coverage and inset token alignment
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- typescript
Línea de trabajo
Start by reviewing the Tearsheet component group and the referenced original PR, then inspect how masthead coverage and the current 4rem inset are implemented. Compare the layout logic with --pf-t--global--spacer--inset--page-chrome and determine the configuration needed for masthead visibility. Done means both masthead behavior and page-chrome alignment match the proposed requirements.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Following design demos and PR feedback, two layout refinements were identified for the Tearsheet component group to maximize vertical screen space and fix horizontal edge alignment with page chrome.
Proposed Updates:
- Masthead Coverage Support
-
Problem: Tearsheets currently display below the masthead, limiting available vertical space compared to large modals.
-
Solution: Allow tearsheets to overlap/cover the masthead area by default or via configuration.
-
Prop Idea: Introduce a prop like coverMasthead (boolean) or showMasthead (boolean) so consumers can toggle masthead visibility based on workflow needs.
- Page Chrome Inset Alignment
-
Problem: The current 4rem (32px) inset creates an ~8px mismatch against standard page chrome (24px inset via --pf-t--global--spacer--inset--page-chrome), causing a sliver of the underlying page container to show along the right edge.
-
Solution: Update width and max-width CSS logic to leverage the design token rather than hardcoded rem values.
-
context from @mcoker's comment from the original PR:
Just an observation (non-blocking IMO) is that the tearsheet inset is about 8px more than our default page chrome/layout inset, so you can see a small bit of the page container behind/along the right edge of the tearsheet.
This is due to the 4rem inset of the tearsheet creating a 32px (2rem) gap on either side, where the page container behind it uses a 24px inset (comes from --pf-t--global--spacer--inset--page-chrome). I imagine the fix would be something like changing the width/max-width to use calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 4) for stack 0, and calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 2) for stack 1. Though if you do that, it's worth noting you should import the tglobalspacerinsetpage*chrome @react-tokens token for the token var instead of hardcoding it.
@GAUNSD @thatblindgeye
Jira Issue: PF-4685
- Lenguaje dominante
- TypeScript
- Estrellas
- 10
- Forks
- 40
- Merge medio
- 3 d 22 h
- PR fusionados (30 d)
- 4
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de patternfly/react-component-groups
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
patternfly/react-component-groups#968 · 1 comentario ·
-
PF Team
patternfly/react-component-groups#979 · 1 asignado ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
-
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
patternfly/react-component-groups#942 · 1 comentario ·
-
rehor-ai-patternfly
Dificultad 2/5 1-3 horas Aptitud para principiantes 58/100
patternfly/react-component-groups#909 · 1 comentario ·
Todos los issues de patternfly/react-component-groups
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
bcgov/bc-wallet-mobile#4761 · 1 comentario ·
-
external-issue to-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
-
area-deployment area-integrations triage:bot-seen
Dificultad 2/5 Medio día Aptitud para principiantes 86/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
-
refactor
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100