Tearsheet layout updates: Masthead coverage and inset token alignment
維護者通常 4 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 48/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- typescript
研究方向
Start by reviewing the Tearsheet component group and the referenced original PR, then inspect how masthead coverage and the current 4rem inset are implemented. Compare the layout logic with --pf-t--global--spacer--inset--page-chrome and determine the configuration needed for masthead visibility. Done means both masthead behavior and page-chrome alignment match the proposed requirements.
由索引模型根據 Issue 內容生成。
描述
Following design demos and PR feedback, two layout refinements were identified for the Tearsheet component group to maximize vertical screen space and fix horizontal edge alignment with page chrome.
Proposed Updates:
- Masthead Coverage Support
-
Problem: Tearsheets currently display below the masthead, limiting available vertical space compared to large modals.
-
Solution: Allow tearsheets to overlap/cover the masthead area by default or via configuration.
-
Prop Idea: Introduce a prop like coverMasthead (boolean) or showMasthead (boolean) so consumers can toggle masthead visibility based on workflow needs.
- Page Chrome Inset Alignment
-
Problem: The current 4rem (32px) inset creates an ~8px mismatch against standard page chrome (24px inset via --pf-t--global--spacer--inset--page-chrome), causing a sliver of the underlying page container to show along the right edge.
-
Solution: Update width and max-width CSS logic to leverage the design token rather than hardcoded rem values.
-
context from @mcoker's comment from the original PR:
Just an observation (non-blocking IMO) is that the tearsheet inset is about 8px more than our default page chrome/layout inset, so you can see a small bit of the page container behind/along the right edge of the tearsheet.
This is due to the 4rem inset of the tearsheet creating a 32px (2rem) gap on either side, where the page container behind it uses a 24px inset (comes from --pf-t--global--spacer--inset--page-chrome). I imagine the fix would be something like changing the width/max-width to use calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 4) for stack 0, and calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 2) for stack 1. Though if you do that, it's worth noting you should import the tglobalspacerinsetpage*chrome @react-tokens token for the token var instead of hardcoding it.
@GAUNSD @thatblindgeye
Jira Issue: PF-4685
- 主要語言
- TypeScript
- 星號
- 10
- 分支
- 40
- 平均合併
- 3 天 22 小時
- 30 天內合併 PR
- 4
環境準備
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
patternfly/react-component-groups 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 72/100
patternfly/react-component-groups#968 · 1 則留言 ·
維護者通常 4 天內回覆
-
Pull in Modal animation support for Tearsheets可能已有人在做 @thatblindgeye 於 9 天前認領。 未關閉PF Team
patternfly/react-component-groups#979 · 已指派 1 人 ·
維護者通常 4 天內回覆
-
難度 3/5 1-2 天 新手友好度 68/100
patternfly/react-component-groups#969 ·
維護者通常 4 天內回覆
-
難度 3/5 1-2 天 新手友好度 55/100
patternfly/react-component-groups#942 · 1 則留言 ·
維護者通常 4 天內回覆
-
rehor-ai-patternfly
難度 2/5 1-3 小時 新手友好度 58/100
patternfly/react-component-groups#909 · 1 則留言 ·
維護者通常 4 天內回覆
查看 patternfly/react-component-groups 的全部 Issue
相似的 Issue
-
ADD openalgo未關閉template
難度 2/5 1-3 小時 新手友好度 75/100
維護者通常 1 天內回覆
-
factory-active factory-automatic task-bug-reproduction-success task-identify-harness-labels-done task-identify-issue-type-done
難度 2/5 1-3 小時 新手友好度 90/100
維護者通常 1 天內回覆
-
bug Needs: Triage :mag:
難度 2/5 1-3 小時 新手友好度 84/100
microsoft/fluentui-contrib#671 ·
-
難度 2/5 1-3 小時 新手友好度 88/100
sveltejs/acorn-typescript#150 ·
-
難度 2/5 1-3 小時 新手友好度 78/100