Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Tearsheet layout updates: Masthead coverage and inset token alignment

Aperta
#985 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
design, frontend

Direzione di ricerca

Start by reviewing the Tearsheet component group and the referenced original PR, then inspect how masthead coverage and the current 4rem inset are implemented. Compare the layout logic with --pf-t--global--spacer--inset--page-chrome and determine the configuration needed for masthead visibility. Done means both masthead behavior and page-chrome alignment match the proposed requirements.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

PF Team

Following design demos and PR feedback, two layout refinements were identified for the Tearsheet component group to maximize vertical screen space and fix horizontal edge alignment with page chrome.

Proposed Updates:

  1. Masthead Coverage Support
  • Problem: Tearsheets currently display below the masthead, limiting available vertical space compared to large modals.

  • Solution: Allow tearsheets to overlap/cover the masthead area by default or via configuration.

  • Prop Idea: Introduce a prop like coverMasthead (boolean) or showMasthead (boolean) so consumers can toggle masthead visibility based on workflow needs.

  1. Page Chrome Inset Alignment
  • Problem: The current 4rem (32px) inset creates an ~8px mismatch against standard page chrome (24px inset via --pf-t--global--spacer--inset--page-chrome), causing a sliver of the underlying page container to show along the right edge.

  • Solution: Update width and max-width CSS logic to leverage the design token rather than hardcoded rem values.

  • context from @mcoker's comment from the original PR:

    Just an observation (non-blocking IMO) is that the tearsheet inset is about 8px more than our default page chrome/layout inset, so you can see a small bit of the page container behind/along the right edge of the tearsheet.
    This is due to the 4rem inset of the tearsheet creating a 32px (2rem) gap on either side, where the page container behind it uses a 24px inset (comes from --pf-t--global--spacer--inset--page-chrome). I imagine the fix would be something like changing the width/max-width to use calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 4) for stack 0, and calc(100% - var(--pf-t--global--spacer--inset--page-chrome * 2) for stack 1. Though if you do that, it's worth noting you should import the tglobalspacerinsetpage*chrome @react-tokens token for the token var instead of hardcoding it.

@GAUNSD @thatblindgeye


Jira Issue: PF-4685

Lingua principale
TypeScript
Stelle
10
Fork
40
Merge medio
3g 22h
PR unite (30g)
4

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di patternfly/react-component-groups

Tutte le issue di patternfly/react-component-groups

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.