With `useScrollendEvent`, scrollToIndex and scrollToEnd stop short when the target moves while they settle

未关闭
#1,375 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@Darkatse 已经在做这个了。

开始于 2026年11月9日。

  • #1376 来自 @Darkatse —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
react, typescript

调研方向

Start with the linked pull request #1376 and the command retirement and reconciliation paths described in the issue. Reproduce the two cases using the linked example's src/main.tsx and the index-shrink button on the command-retire e2e page. Done means both scrollToIndex and scrollToEnd reach their targets with useScrollendEvent: true, including when rows move while the command settles.

由索引模型根据 Issue 内容生成。

描述

Describe the bug

With useScrollendEvent: true, a scrollToIndex or scrollToEnd can stop before its target with no user input. It happens when the target moves while the command is settling. I found two ways:

  1. In one ResizeObserver batch, a row above the viewport grows (the virtualizer corrects the scroll position for it) and a row in the viewport above the target grows too (no correction). The target moves further than the correction, and the command ends where the correction left the view.
  2. Rows above the target shrink before the command's write is reported back (#1310). The browser clamps the write at the smaller max, and the command ends there.

With the default useScrollendEvent: false, both land on the target.

Your minimal, reproducible example

Live: https://virtual-scrollend-repro.darkatse.workers.dev
Source: https://github.com/Darkatse/virtual-scrollend-repro

It shows case 1 with the published @tanstack/react-virtual 3.14.26, pinned. All the code is in src/main.tsx, and it depends only on React.

Steps to reproduce

  1. Open the page and click Run. It calls scrollToIndex(60, { align: 'center' }). In the frame after its scroll event, row 55 grows to 100px and row 58 to 150px.
  2. Click run with false (useScrollendEvent: false), then click Run again.

Case 2: the index-shrink button on the command-retire e2e page, with useScrollendEvent: true on its virtualizer, ends at 4000 instead of 3900 in Chromium. WebKit fires no scrollend there.

Expected behavior

Both runs end with row 60 centred on the dashed line (scrollTop 2975).

Actual behavior

With useScrollendEvent: true the run ends at scrollTop 2875, 100px short, and the command has ended. With false it lands on 2975.

How often does this bug happen?

Every time

Platform

  • macOS 27.2, Chromium 156.0.8078.4 and WebKit 26.0 (Playwright builds); the same result in both.
  • Also seen in a chat app on Android WebView and iOS.

tanstack-virtual version

@tanstack/react-virtual 3.14.26 (@tanstack/virtual-core 3.19.11). Present since virtual-core 3.18.0 (scroll events retire commands, #1294) through main.

TypeScript version

5.9.3

Additional context

Each scroll write is reported a second time when the element comes to rest, and the virtualizer reads that second report as an external scroll, as if the user had scrolled away. With useScrollendEvent it is a scrollend at the same position in the same frame, so it arrives before reconcile has written the moved target. externalRetiresCommand sees the element neither where the command last wrote nor at the fresh target, and ends the command. With the debounced fallback, the second report comes after reconcile.

I have a fix and will open a PR.

主要语言
TypeScript
星标
7.2k
派生
495
平均合并
23 小时 16 分钟
30 天内合并 PR
19

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/virtual 的其他 Issue

查看 TanStack/virtual 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。