With `useScrollendEvent`, scrollToIndex and scrollToEnd stop short when the target moves while they settle
Mantenedores costumam responder em até 1 dia
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 25/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Estagnada
- Stack de tecnologia
- react, typescript
- Domínio
- frontend, performance
Direção de pesquisa
Start with the linked pull request #1376 and the command retirement and reconciliation paths described in the issue. Reproduce the two cases using the linked example's src/main.tsx and the index-shrink button on the command-retire e2e page. Done means both scrollToIndex and scrollToEnd reach their targets with useScrollendEvent: true, including when rows move while the command settles.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Describe the bug
With useScrollendEvent: true, a scrollToIndex or scrollToEnd can stop before its target with no user input. It happens when the target moves while the command is settling. I found two ways:
- In one ResizeObserver batch, a row above the viewport grows (the virtualizer corrects the scroll position for it) and a row in the viewport above the target grows too (no correction). The target moves further than the correction, and the command ends where the correction left the view.
- Rows above the target shrink before the command's write is reported back (#1310). The browser clamps the write at the smaller max, and the command ends there.
With the default useScrollendEvent: false, both land on the target.
Your minimal, reproducible example
Live: https://virtual-scrollend-repro.darkatse.workers.dev
Source: https://github.com/Darkatse/virtual-scrollend-repro
It shows case 1 with the published @tanstack/react-virtual 3.14.26, pinned. All the code is in src/main.tsx, and it depends only on React.
Steps to reproduce
- Open the page and click Run. It calls
scrollToIndex(60, { align: 'center' }). In the frame after its scroll event, row 55 grows to 100px and row 58 to 150px. - Click run with false (
useScrollendEvent: false), then click Run again.
Case 2: the index-shrink button on the command-retire e2e page, with useScrollendEvent: true on its virtualizer, ends at 4000 instead of 3900 in Chromium. WebKit fires no scrollend there.
Expected behavior
Both runs end with row 60 centred on the dashed line (scrollTop 2975).
Actual behavior
With useScrollendEvent: true the run ends at scrollTop 2875, 100px short, and the command has ended. With false it lands on 2975.
How often does this bug happen?
Every time
Platform
- macOS 27.2, Chromium 156.0.8078.4 and WebKit 26.0 (Playwright builds); the same result in both.
- Also seen in a chat app on Android WebView and iOS.
tanstack-virtual version
@tanstack/react-virtual 3.14.26 (@tanstack/virtual-core 3.19.11). Present since virtual-core 3.18.0 (scroll events retire commands, #1294) through main.
TypeScript version
5.9.3
Additional context
Each scroll write is reported a second time when the element comes to rest, and the virtualizer reads that second report as an external scroll, as if the user had scrolled away. With useScrollendEvent it is a scrollend at the same position in the same frame, so it arrives before reconcile has written the moved target. externalRetiresCommand sees the element neither where the command last wrote nor at the fresh target, and ends the command. With the debounced fallback, the second report comes after reconcile.
I have a fix and will open a PR.
- Linguagem predominante
- TypeScript
- Estrelas
- 7.2k
- Forks
- 495
- Merge médio
- 23h 16min
- PRs com merge (30d)
- 19
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de TanStack/virtual
-
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 55/100
Mantenedores costumam responder em até 1 dia
-
svelte-virtual renders no rows when the scroll element is bound after the store subscribesTalvez já em andamento @clean99 assumiu há 13 dias. Aberta
Dificuldade 4/5 1-2 dias Facilidade para iniciantes 35/100
Mantenedores costumam responder em até 1 dia
-
anchorTo: 'end' does not keep the reading position when only paddingStart changesTalvez já em andamento @duongynhi000001-crypto assumiu há 13 dias. Aberta
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 30/100
Mantenedores costumam responder em até 1 dia
-
anchorTo: 'end' loses the end when the scroll element shrinksTalvez já em andamento @langleyd assumiu há 41 dias. Aberta
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 68/100
Mantenedores costumam responder em até 1 dia
-
marko-virtual: scrollToEnd during an in-flight prepend strands the view one prepend above the bottom (chat-pretext e2e fails on CI)Talvez já em andamento @officialasishkumar assumiu há 15 dias. Aberta
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 55/100
Mantenedores costumam responder em até 1 dia
Todas as issues de TanStack/virtual
Issues semelhantes
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
hemilabs/ui-monorepo#2711 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
code-yeongyu/senpi#6929 ·
Mantenedores costumam responder em até 1 dia
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 72/100
lingdojo/kana-dojo#34261 · 1 comentário · 5 reações ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
embedpdf/embed-pdf-viewer#1116 ·
Mantenedores costumam responder em até 1 dia
-
Revise communication normsAbertacurrent task
Dificuldade 1/5 1-3 horas Facilidade para iniciantes 88/100
Sunday-School-Software/Sunday-School-Scheduler#87 ·
Mantenedores costumam responder em até 1 dia