laneAssignmentMode 'measured': is it intended that a row measured at exactly its estimate can change lanes?
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- react, typescript
- 领域
- frontend
调研方向
Start in tests/index.test.ts, which the issue names as the place that reads the private measurement method, and trace how resizeItem handles sizes equal to estimateSize in measured lane assignment. Add a regression case based on the reproducer, then check whether lanes remain stable after row 1 grows; the issue leaves the intended behavior unresolved, so confirm that before changing behavior.
由索引模型根据 Issue 内容生成。
描述
Describe the bug
With lanes > 1 and laneAssignmentMode: 'measured', a row whose first measurement exactly equals estimateSize doesn't get its lane cached, because resizeItem records a measurement only when the size changes. When a row above it grows later, that row is placed again and can move to another lane. A row measured at any other size keeps its lane.
Your minimal, reproducible example
import { Virtualizer } from '@tanstack/virtual-core'
const measureThenGrow = (height: number) => {
const virtualizer = new Virtualizer({
count: 8,
lanes: 2,
estimateSize: () => 100,
laneAssignmentMode: 'measured',
getScrollElement: () => null,
scrollToFn: () => {},
observeElementRect: () => {},
observeElementOffset: () => {},
})
// getMeasurements is private; tests/index.test.ts reads it the same way.
const lanes = () =>
virtualizer['getMeasurements']().map((m) => m.lane).join(' ')
lanes() // Build the measurements first; resizeItem needs them.
for (let i = 0; i < 8; i++) virtualizer.resizeItem(i, height)
const measured = lanes()
virtualizer.resizeItem(1, 500)
return { measured, grown: lanes() }
}
console.log(measureThenGrow(100))
// { measured: '0 1 0 1 0 1 0 1', grown: '0 1 0 0 0 0 1 0' }
console.log(measureThenGrow(101))
// { measured: '0 1 0 1 0 1 0 1', grown: '0 1 0 1 0 1 0 1' }
Steps to reproduce
- Run the example above.
- At 100, row 1 growing moves rows 3, 5, 6 and 7 to another lane.
- At 101, every row keeps its lane.
Expected behavior
I can't tell which behavior is intended, so I'd like to ask before going further.
- If this is not intended, a row measured at exactly its estimate should keep its lane like any other measured row, since the docs say lanes are cached and remain stable after the initial measurement. #1377 is a draft of that fix.
- If this is intended, for example so that a placeholder sized like the estimate can rebalance once its content loads, there is nothing to fix and I'll close #1377.
Is this behavior intended?
How often does this bug happen?
Every time
Platform
Any. This is in virtual-core.
tanstack-virtual version
3.19.11
TypeScript version
n/a
Terms & Code of Conduct
- I agree to follow this project's Code of Conduct
- I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
- 主要语言
- TypeScript
- 星标
- 7.2k
- 派生
- 495
- 平均合并
- 23 小时 16 分钟
- 30 天内合并 PR
- 19
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TanStack/virtual 的其他 Issue
-
With `useScrollendEvent`, scrollToIndex and scrollToEnd stop short when the target moves while they settle可能已有人在做 @Darkatse 于 8 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 25/100
维护者通常 1 天内回复
-
svelte-virtual renders no rows when the scroll element is bound after the store subscribes可能已有人在做 @clean99 于 13 天前认领。 未关闭
难度 4/5 1-2 天 新手友好度 35/100
维护者通常 1 天内回复
-
anchorTo: 'end' does not keep the reading position when only paddingStart changes可能已有人在做 @duongynhi000001-crypto 于 12 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 30/100
维护者通常 1 天内回复
-
anchorTo: 'end' loses the end when the scroll element shrinks可能已有人在做 @langleyd 于 41 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 68/100
维护者通常 1 天内回复
-
marko-virtual: scrollToEnd during an in-flight prepend strands the view one prepend above the bottom (chat-pretext e2e fails on CI)可能已有人在做 @officialasishkumar 于 15 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 55/100
维护者通常 1 天内回复
相似的 Issue
-
难度 1/5 1-3 小时 新手友好度 83/100
gofish-graphics/gofish-graphics#1384 ·
维护者通常 1 天内回复
-
adapter bug
难度 2/5 1-3 小时 新手友好度 83/100
Olanetsoft/agent-lookout#353 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
vicharanashala/vibe#1542 ·
维护者通常 1 天内回复
-
bug chore P2 size:XS
难度 2/5 1-3 小时 新手友好度 77/100
josephfung/curia#2666 ·
维护者通常 1 天内回复
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 84/100
devarshishimpi/codra#178 ·
维护者通常 1 天内回复