With `useScrollendEvent`, scrollToIndex and scrollToEnd stop short when the target moves while they settle
Maintainer antworten meist innerhalb von 1 Tag
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 25/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Veraltet
- Tech-Stack
- react, typescript
- Bereich
- frontend, performance
Rechercherichtung
Start with the linked pull request #1376 and the command retirement and reconciliation paths described in the issue. Reproduce the two cases using the linked example's src/main.tsx and the index-shrink button on the command-retire e2e page. Done means both scrollToIndex and scrollToEnd reach their targets with useScrollendEvent: true, including when rows move while the command settles.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Describe the bug
With useScrollendEvent: true, a scrollToIndex or scrollToEnd can stop before its target with no user input. It happens when the target moves while the command is settling. I found two ways:
- In one ResizeObserver batch, a row above the viewport grows (the virtualizer corrects the scroll position for it) and a row in the viewport above the target grows too (no correction). The target moves further than the correction, and the command ends where the correction left the view.
- Rows above the target shrink before the command's write is reported back (#1310). The browser clamps the write at the smaller max, and the command ends there.
With the default useScrollendEvent: false, both land on the target.
Your minimal, reproducible example
Live: https://virtual-scrollend-repro.darkatse.workers.dev
Source: https://github.com/Darkatse/virtual-scrollend-repro
It shows case 1 with the published @tanstack/react-virtual 3.14.26, pinned. All the code is in src/main.tsx, and it depends only on React.
Steps to reproduce
- Open the page and click Run. It calls
scrollToIndex(60, { align: 'center' }). In the frame after its scroll event, row 55 grows to 100px and row 58 to 150px. - Click run with false (
useScrollendEvent: false), then click Run again.
Case 2: the index-shrink button on the command-retire e2e page, with useScrollendEvent: true on its virtualizer, ends at 4000 instead of 3900 in Chromium. WebKit fires no scrollend there.
Expected behavior
Both runs end with row 60 centred on the dashed line (scrollTop 2975).
Actual behavior
With useScrollendEvent: true the run ends at scrollTop 2875, 100px short, and the command has ended. With false it lands on 2975.
How often does this bug happen?
Every time
Platform
- macOS 27.2, Chromium 156.0.8078.4 and WebKit 26.0 (Playwright builds); the same result in both.
- Also seen in a chat app on Android WebView and iOS.
tanstack-virtual version
@tanstack/react-virtual 3.14.26 (@tanstack/virtual-core 3.19.11). Present since virtual-core 3.18.0 (scroll events retire commands, #1294) through main.
TypeScript version
5.9.3
Additional context
Each scroll write is reported a second time when the element comes to rest, and the virtualizer reads that second report as an external scroll, as if the user had scrolled away. With useScrollendEvent it is a scrollend at the same position in the same frame, so it arrives before reconcile has written the moved target. externalRetiresCommand sees the element neither where the command last wrote nor at the fresh target, and ends the command. With the debounced fallback, the second report comes after reconcile.
I have a fix and will open a PR.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 7.2k
- Forks
- 495
- Ø Merge
- 23 Std. 16 Min.
- Gemergte PRs (30 T.)
- 19
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus TanStack/virtual
-
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 55/100
Maintainer antworten meist innerhalb von 1 Tag
-
svelte-virtual renders no rows when the scroll element is bound after the store subscribesEvtl. vergeben @clean99 hat das vor 13 Tagen übernommen. Offen
Schwierigkeit 4/5 1-2 Tage Anfängerfreundlichkeit 35/100
Maintainer antworten meist innerhalb von 1 Tag
-
anchorTo: 'end' does not keep the reading position when only paddingStart changesEvtl. vergeben @duongynhi000001-crypto hat das vor 12 Tagen übernommen. Offen
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 30/100
Maintainer antworten meist innerhalb von 1 Tag
-
anchorTo: 'end' loses the end when the scroll element shrinksEvtl. vergeben @langleyd hat das vor 41 Tagen übernommen. Offen
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 68/100
Maintainer antworten meist innerhalb von 1 Tag
-
marko-virtual: scrollToEnd during an in-flight prepend strands the view one prepend above the bottom (chat-pretext e2e fails on CI)Evtl. vergeben @officialasishkumar hat das vor 15 Tagen übernommen. Offen
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 55/100
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in TanStack/virtual
Ähnliche Issues
-
Schwierigkeit 1/5 1-3 Stunden Anfängerfreundlichkeit 83/100
gofish-graphics/gofish-graphics#1384 ·
Maintainer antworten meist innerhalb von 1 Tag
-
adapter bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 83/100
Olanetsoft/agent-lookout#353 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
vicharanashala/vibe#1542 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug chore P2 size:XS
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 77/100
josephfung/curia#2666 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug good first issue
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
devarshishimpi/codra#178 ·
Maintainer antworten meist innerhalb von 1 Tag