With `useScrollendEvent`, scrollToIndex and scrollToEnd stop short when the target moves while they settle

未關閉
#1,375 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@Darkatse 已經在處理了。

開始於 2026年11月9日。

  • #1376 來自 @Darkatse —— 未關閉

評估

難度
4/5
預估耗時
3-5 天
新手友好度
25/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
react, typescript

研究方向

Start with the linked pull request #1376 and the command retirement and reconciliation paths described in the issue. Reproduce the two cases using the linked example's src/main.tsx and the index-shrink button on the command-retire e2e page. Done means both scrollToIndex and scrollToEnd reach their targets with useScrollendEvent: true, including when rows move while the command settles.

由索引模型根據 Issue 內容生成。

描述

Describe the bug

With useScrollendEvent: true, a scrollToIndex or scrollToEnd can stop before its target with no user input. It happens when the target moves while the command is settling. I found two ways:

  1. In one ResizeObserver batch, a row above the viewport grows (the virtualizer corrects the scroll position for it) and a row in the viewport above the target grows too (no correction). The target moves further than the correction, and the command ends where the correction left the view.
  2. Rows above the target shrink before the command's write is reported back (#1310). The browser clamps the write at the smaller max, and the command ends there.

With the default useScrollendEvent: false, both land on the target.

Your minimal, reproducible example

Live: https://virtual-scrollend-repro.darkatse.workers.dev
Source: https://github.com/Darkatse/virtual-scrollend-repro

It shows case 1 with the published @tanstack/react-virtual 3.14.26, pinned. All the code is in src/main.tsx, and it depends only on React.

Steps to reproduce

  1. Open the page and click Run. It calls scrollToIndex(60, { align: 'center' }). In the frame after its scroll event, row 55 grows to 100px and row 58 to 150px.
  2. Click run with false (useScrollendEvent: false), then click Run again.

Case 2: the index-shrink button on the command-retire e2e page, with useScrollendEvent: true on its virtualizer, ends at 4000 instead of 3900 in Chromium. WebKit fires no scrollend there.

Expected behavior

Both runs end with row 60 centred on the dashed line (scrollTop 2975).

Actual behavior

With useScrollendEvent: true the run ends at scrollTop 2875, 100px short, and the command has ended. With false it lands on 2975.

How often does this bug happen?

Every time

Platform

  • macOS 27.2, Chromium 156.0.8078.4 and WebKit 26.0 (Playwright builds); the same result in both.
  • Also seen in a chat app on Android WebView and iOS.

tanstack-virtual version

@tanstack/react-virtual 3.14.26 (@tanstack/virtual-core 3.19.11). Present since virtual-core 3.18.0 (scroll events retire commands, #1294) through main.

TypeScript version

5.9.3

Additional context

Each scroll write is reported a second time when the element comes to rest, and the virtualizer reads that second report as an external scroll, as if the user had scrolled away. With useScrollendEvent it is a scrollend at the same position in the same frame, so it arrives before reconcile has written the moved target. externalRetiresCommand sees the element neither where the command last wrote nor at the fresh target, and ends the command. With the debounced fallback, the second report comes after reconcile.

I have a fix and will open a PR.

主要語言
TypeScript
星號
7.2k
分支
495
平均合併
23 小時 16 分鐘
30 天內合併 PR
19

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TanStack/virtual 的其他 Issue

查看 TanStack/virtual 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。