Review player: limit a redaction box to a time window

未关闭
#377 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@lucky0559 已经在做这个了。

开始于 2026年11月19日。

  • #381 来自 @lucky0559 —— 已关闭,未合并
  • #382 来自 @lucky0559 —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
停滞
技术栈
typescript
领域
frontend

调研方向

Start with assets/ui/player.html and assets/ui/player.js to trace the box form, box list, stage drawing, and export; read src/tools/redactRegion.ts for the existing start and end behavior. Run npm test and inspect the generated regions assertion. Done means boxes can be time-limited by pointer and keyboard, display only while active, and export their window; an open linked pull request indicates work is already underway.

由索引模型根据 Issue 内容生成。

描述

effort: small enhancement good first issue priority: medium

Summary

Redaction boxes drawn in the review player cover the whole kept range. redact_region and pipeline redact already support a start..end window per region, but the player cannot set one. A notification that sits on screen for 3 seconds gets blurred for the whole video.

Where

  • assets/ui/player.html:137-146 (box form: X, Y, W, H only)
  • assets/ui/player.js:367 (regions: S.boxes.map((b) => ({ ...b })), with no time fields)
  • src/tools/redactRegion.ts:15 ("each optionally limited to start..end seconds")

Suggested fix

  • A new box defaults to "whole video". Add a From playhead / To playhead pair (or a small range on the timeline under the box) to limit it.
  • Show each box's window in #boxList (01:10.0–01:13.5) and only draw a box on the stage while the playhead is inside its window.
  • Export includes start/end when set.

Acceptance criteria

  • Boxes can be limited to a time window, by pointer and by keyboard
  • Stage shows only the boxes active at the current frame
  • Export passes the window. A test checks the generated regions

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html
  • Tests: npm test

Filed by repo-audit/feature-ideas at 1ac339f. Severity: medium. Effort: S. audit-key: enhancement|assets/ui/player.js|boxTimeRange

主要语言
TypeScript
星标
1
派生
4
平均合并
8 小时 17 分钟
30 天内合并 PR
46

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/screencast-mcp 的其他 Issue

查看 TMHSDigital/screencast-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。