Disarming a triggered recording while it starts says "nothing was recorded", but the recording starts

未关闭
#342 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
78/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
领域
backend, testing

调研方向

Read src/utils/triggers.ts around disarm and armStart, then inspect the disarm branch in src/tools/stopRecording.ts and the trigger tests in src/__tests__/triggers.test.ts. Run npm test to see the existing behavior. Add a delayed fake fire test; done means stopping during startup leaves no live session and the response accurately reports that the session was stopped.

由索引模型根据 Issue 内容生成。

描述

bug effort: small priority: medium

Summary

When startWhen fires, armStart runs the whole start (await o.fire()) while the arm's status is still "armed". A stop_recording on the arm id during that window takes the disarm branch and reports cancelled / "Disarmed; nothing was recorded.", but the start then finishes and a recording runs until its cap.

Where

  • src/utils/triggers.ts:59-65 (disarm only checks status !== "armed")
  • src/utils/triggers.ts:147-151 (fire() awaited without changing status, then status = "started")
  • src/tools/stopRecording.ts:86-90 (disarm branch)
  • src/tools/startRecording.ts:489 (the fired start runs the full handler: target resolution, event logger, encoder probe, settle)

Impact

The agent and the user are told the armed capture was cancelled and nothing was recorded, while the screen (and the input-event log if requested) is recorded a moment later for up to the cap (default 1 h). Nothing in the response shows that a session exists.

Steps to reproduce

  1. start_recording {"target":"full","startWhen":{"window":"window:Notepad"},"events":true}
  2. Open Notepad, and within 1-3 s (while the start runs) call stop_recording {"sessionId":"arm-..."}. The response is status: "cancelled".
  3. A few seconds later, list_sessions shows a new recording session.

Suggested fix

Set a distinct status (e.g. "starting") before await o.fire(). In stop_recording, for a "starting" arm, record a cancel request that armStart honours by stopping the session as soon as fire returns (or await the fire's promise and then stop the session). Report "nothing was recorded" only for an arm that was still waiting.

Acceptance criteria

  • Stopping an arm whose start is in progress stops the session it produces, and the response says so.
  • Test with a fake fire that resolves after a delay: stop during the delay leaves no live session.

Getting started

  • Relevant files: src/utils/triggers.ts, src/tools/stopRecording.ts, src/__tests__/triggers.test.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: S. audit-key: bug|src/utils/triggers.ts|armStart

主要语言
TypeScript
星标
1
派生
4
平均合并
14 小时 8 分钟
30 天内合并 PR
48

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/screencast-mcp 的其他 Issue

查看 TMHSDigital/screencast-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。