pause/resume report "Already paused/recording" while the other operation is still running
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 82/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- node.js, typescript
调研方向
阅读 src/tools/pauseRecording.ts 和 src/tools/resumeRecording.ts,并查看定义了 sessionOpInFlight 和 withSessionOp 的 src/utils/lifecycle.ts。检查每个工具在返回“已暂停”或“正在录制”状态之前如何处理正在进行的操作。添加所要求的单元测试,并使用存根模拟缓慢的暂停操作,然后运行 npm test;两个重叠操作案例都返回重试错误即为完成。
由索引模型根据 Issue 内容生成。
描述
Summary
resume_recording and pause_recording return early based on the persisted status, before the per-session operation lock. runPause keeps the record at status: "recording" until the segment has quit and been probed (up to the 8 s graceful wait plus ffprobe), so a resume in that window returns "Already recording." and the session then ends up paused. The mirror case applies to pause during a resume.
Where
src/tools/resumeRecording.ts:28-34,src/tools/pauseRecording.ts:28-34(status short-circuit)src/utils/lifecycle.ts:141-147(withSessionOpis meant to reject a colliding operation)src/utils/lifecycle.ts:237-238(status written only after the pause finishes)sessionOpInFlightexists for this check but no tool calls it
Impact
An agent that pauses and then quickly resumes (or a client that retries or parallelizes calls) is told the recording is running when it is paused, so the rest of the task is not captured. In the mirror case it is told capture is paused while it is still recording the screen.
Steps to reproduce
start_recording {"target":"full"}- Call
pause_recording, and before it returns callresume_recordingwith the same id. Resume returns{status:"recording", note:"Already recording."}. - After pause returns,
get_sessionshowsstatus: "paused".
Suggested fix
In both tools, check sessionOpInFlight(store, id) before the status short-circuit and throw the same "a of it is in progress; retry" error that withSessionOp uses. Report "Already paused/recording" only when no operation is in flight.
Acceptance criteria
- resume during an in-flight pause (and pause during an in-flight resume) returns an error asking to retry.
- Unit test with a stubbed slow pause.
Getting started
- Relevant files:
src/tools/pauseRecording.ts,src/tools/resumeRecording.ts,src/utils/lifecycle.ts - How to run tests:
npm test
Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: S. audit-key: bug|src/tools/resumeRecording.ts|register
- 主要语言
- TypeScript
- 星标
- 1
- 派生
- 4
- 平均合并
- 14 小时 8 分钟
- 30 天内合并 PR
- 48
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TMHSDigital/screencast-mcp 的其他 Issue
-
effort: small good first issue priority: medium testing
难度 2/5 1-3 小时 新手友好度 84/100
TMHSDigital/screencast-mcp#351 ·
维护者通常 1 天内回复
-
bug effort: small priority: medium
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/screencast-mcp#344 ·
维护者通常 1 天内回复
-
effort: medium help wanted priority: medium testing
难度 3/5 1-2 天 新手友好度 76/100
TMHSDigital/screencast-mcp#350 ·
维护者通常 1 天内回复
-
effort: medium priority: medium testing
难度 4/5 1-2 天 新手友好度 70/100
TMHSDigital/screencast-mcp#349 ·
维护者通常 1 天内回复
-
effort: medium help wanted priority: medium testing
难度 3/5 1-2 天 新手友好度 65/100
TMHSDigital/screencast-mcp#348 ·
维护者通常 1 天内回复
查看 TMHSDigital/screencast-mcp 的全部 Issue
相似的 Issue
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
难度 2/5 1-3 小时 新手友好度 82/100
openclaw/openclaw#200365 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
area-templates triage:bot-seen triage:needs-human
难度 2/5 1-3 小时 新手友好度 75/100
microsoft/aspire#22356 · 1 条评论 ·
维护者通常 1 天内回复
-
Archiving an agent that is not loaded keeps its old updatedAt可能已有人在做 @luoph 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
content triage
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复