Disarming a triggered recording while it starts says "nothing was recorded", but the recording starts

Offen
#342 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
78/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
node.js, typescript
Bereich
backend, testing

Rechercherichtung

Read src/utils/triggers.ts around disarm and armStart, then inspect the disarm branch in src/tools/stopRecording.ts and the trigger tests in src/__tests__/triggers.test.ts. Run npm test to see the existing behavior. Add a delayed fake fire test; done means stopping during startup leaves no live session and the response accurately reports that the session was stopped.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug effort: small priority: medium

Summary

When startWhen fires, armStart runs the whole start (await o.fire()) while the arm's status is still "armed". A stop_recording on the arm id during that window takes the disarm branch and reports cancelled / "Disarmed; nothing was recorded.", but the start then finishes and a recording runs until its cap.

Where

  • src/utils/triggers.ts:59-65 (disarm only checks status !== "armed")
  • src/utils/triggers.ts:147-151 (fire() awaited without changing status, then status = "started")
  • src/tools/stopRecording.ts:86-90 (disarm branch)
  • src/tools/startRecording.ts:489 (the fired start runs the full handler: target resolution, event logger, encoder probe, settle)

Impact

The agent and the user are told the armed capture was cancelled and nothing was recorded, while the screen (and the input-event log if requested) is recorded a moment later for up to the cap (default 1 h). Nothing in the response shows that a session exists.

Steps to reproduce

  1. start_recording {"target":"full","startWhen":{"window":"window:Notepad"},"events":true}
  2. Open Notepad, and within 1-3 s (while the start runs) call stop_recording {"sessionId":"arm-..."}. The response is status: "cancelled".
  3. A few seconds later, list_sessions shows a new recording session.

Suggested fix

Set a distinct status (e.g. "starting") before await o.fire(). In stop_recording, for a "starting" arm, record a cancel request that armStart honours by stopping the session as soon as fire returns (or await the fire's promise and then stop the session). Report "nothing was recorded" only for an arm that was still waiting.

Acceptance criteria

  • Stopping an arm whose start is in progress stops the session it produces, and the response says so.
  • Test with a fake fire that resolves after a delay: stop during the delay leaves no live session.

Getting started

  • Relevant files: src/utils/triggers.ts, src/tools/stopRecording.ts, src/__tests__/triggers.test.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: S. audit-key: bug|src/utils/triggers.ts|armStart

Vorherrschende Sprache
TypeScript
Sterne
1
Forks
4
Ø Merge
14 Std. 8 Min.
Gemergte PRs (30 T.)
48

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/screencast-mcp

Alle Issues in TMHSDigital/screencast-mcp

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.