Disarming a triggered recording while it starts says "nothing was recorded", but the recording starts

オープン
#342 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
78/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
node.js, typescript
領域
backend, testing

調査の方向性

Read src/utils/triggers.ts around disarm and armStart, then inspect the disarm branch in src/tools/stopRecording.ts and the trigger tests in src/__tests__/triggers.test.ts. Run npm test to see the existing behavior. Add a delayed fake fire test; done means stopping during startup leaves no live session and the response accurately reports that the session was stopped.

索引モデルが issue の本文から書いたものです。

説明

bug effort: small priority: medium

Summary

When startWhen fires, armStart runs the whole start (await o.fire()) while the arm's status is still "armed". A stop_recording on the arm id during that window takes the disarm branch and reports cancelled / "Disarmed; nothing was recorded.", but the start then finishes and a recording runs until its cap.

Where

  • src/utils/triggers.ts:59-65 (disarm only checks status !== "armed")
  • src/utils/triggers.ts:147-151 (fire() awaited without changing status, then status = "started")
  • src/tools/stopRecording.ts:86-90 (disarm branch)
  • src/tools/startRecording.ts:489 (the fired start runs the full handler: target resolution, event logger, encoder probe, settle)

Impact

The agent and the user are told the armed capture was cancelled and nothing was recorded, while the screen (and the input-event log if requested) is recorded a moment later for up to the cap (default 1 h). Nothing in the response shows that a session exists.

Steps to reproduce

  1. start_recording {"target":"full","startWhen":{"window":"window:Notepad"},"events":true}
  2. Open Notepad, and within 1-3 s (while the start runs) call stop_recording {"sessionId":"arm-..."}. The response is status: "cancelled".
  3. A few seconds later, list_sessions shows a new recording session.

Suggested fix

Set a distinct status (e.g. "starting") before await o.fire(). In stop_recording, for a "starting" arm, record a cancel request that armStart honours by stopping the session as soon as fire returns (or await the fire's promise and then stop the session). Report "nothing was recorded" only for an arm that was still waiting.

Acceptance criteria

  • Stopping an arm whose start is in progress stops the session it produces, and the response says so.
  • Test with a fake fire that resolves after a delay: stop during the delay leaves no live session.

Getting started

  • Relevant files: src/utils/triggers.ts, src/tools/stopRecording.ts, src/__tests__/triggers.test.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: S. audit-key: bug|src/utils/triggers.ts|armStart

主要言語
TypeScript
スター
1
フォーク
4
平均マージ
14時間 8分
マージ済み PR(30日)
48

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TMHSDigital/screencast-mcp のほかの issue

TMHSDigital/screencast-mcp の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。