Tests for the start_recording startWhen/stopWhen arm path and its consent carry-over
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 1-2 天
- 新手友好度
- 70/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript
调研方向
Read src/tools/startRecording.ts around the listed arm and watcher paths, then inspect src/__tests__/startRecording.test.ts, src/__tests__/consentLogging.test.ts, and src/utils/triggers.ts. Extend the fake spawn tests with an elicitation capable client and mocked window and text checks, then run npm test. Done means the listed startWhen, consent carry-over, failed arm, and stopWhen cases pass.
由索引模型根据 Issue 内容生成。
描述
Summary
armRecording asks for consent once at arm time, adds the args object to approvedAtArm, and later calls tool.handler(startArgs, ...). prepareStart skips the consent prompt when approvedAtArm.has(args). This relies on the handler receiving the very same object. watchStopWhen stops a session when OCR text appears. No test covers startWhen, stopWhen or approvedAtArm: triggers.test.ts covers only the utils. startRecording.ts is the highest-churn file and is at 47% lines / 34% branches locally.
Where
src/tools/startRecording.ts:237, 450-461, 466-511, 538, 654src/__tests__/triggers.test.ts:41-54
Impact
If a refactor or the SDK clones args before the handler, armed recordings either re-prompt (and fail when no one is there) or, worse, a change to the WeakSet logic lets an unarmed call skip consent.
Suggested fix
Extend src/__tests__/startRecording.test.ts (fake spawn) with an elicitation-capable client (the pattern in src/__tests__/consentLogging.test.ts:76-77) and mocked window/text checks:
- startWhen
{}: isError "startWhen needs window and/or text." - startWhen
{window}: status "armed" with anarm-id, and consent asked exactly once. - When the condition is met, a session starts through the same handler and the elicitation handler is not called a second time.
- A plain start_recording after an arm still prompts (approval does not leak).
- Consent declined at arm: isError, and no arm is registered.
- fire() returning isError: arm status "failed" with that error text.
- stopWhen text met: the session stops with the stopWhen reason; a session that ends first aborts the watcher.
Getting started
- Relevant files:
src/tools/startRecording.ts,src/utils/triggers.ts - How to run tests:
npm test
Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: M. audit-key: testing|src/tools/startRecording.ts|armRecording
- 主要语言
- TypeScript
- 星标
- 1
- 派生
- 4
- 平均合并
- 14 小时 8 分钟
- 30 天内合并 PR
- 48
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TMHSDigital/screencast-mcp 的其他 Issue
-
effort: small good first issue priority: medium testing
难度 2/5 1-3 小时 新手友好度 84/100
TMHSDigital/screencast-mcp#351 ·
维护者通常 1 天内回复
-
bug effort: small priority: medium
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/screencast-mcp#344 ·
维护者通常 1 天内回复
-
bug effort: small good first issue priority: medium
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/screencast-mcp#343 ·
维护者通常 1 天内回复
-
effort: medium help wanted priority: medium testing
难度 3/5 1-2 天 新手友好度 76/100
TMHSDigital/screencast-mcp#350 ·
维护者通常 1 天内回复
-
effort: medium help wanted priority: medium testing
难度 3/5 1-2 天 新手友好度 65/100
TMHSDigital/screencast-mcp#348 ·
维护者通常 1 天内回复
查看 TMHSDigital/screencast-mcp 的全部 Issue
相似的 Issue
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
难度 2/5 1-3 小时 新手友好度 82/100
openclaw/openclaw#200365 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
area-templates triage:bot-seen triage:needs-human
难度 2/5 1-3 小时 新手友好度 75/100
microsoft/aspire#22356 · 1 条评论 ·
维护者通常 1 天内回复
-
Archiving an agent that is not loaded keeps its old updatedAt可能已有人在做 @luoph 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
content triage
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复