lint_project and project_report return unbounded, pretty-printed findings

未关闭
#129 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
58/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
api, performance

调研方向

Start by reading src/tools/lint.ts and src/tools/scenes.ts at the cited locations, then inspect src/tools/result.ts and the generated tool definitions. Compare the response shape with the acceptance criteria: lint_project should cap findings by default and include the total and truncation flag, while summary mode should return counts only. Run npm run generate:tools after changes.

由索引模型根据 Issue 内容生成。

描述

help wanted performance severity: medium

Summary

lint_project and project_report return every finding in one pretty-printed text block, with no limit, paging or summary mode. On a realistic untyped project this is tens of megabytes, far beyond what an MCP client or LLM context can take.

Where

  • src/tools/lint.ts:65, src/tools/scenes.ts:100
  • src/tools/result.ts:9 (JSON.stringify(data, null, 2))

Details

A synthetic project with 3000 scripts produced 108k lint findings: 90k untyped-declaration, which is on by default, plus 6k stringly-nodepath. JSON output was 37.3 MB for lint and 39.5 MB for report. Even 10k findings is about 3.5 MB. The server-side cost (sort 264 ms, stringify 154 ms) is small; the problem is the size of the response.

Impact

On real projects that do not use static typing, the main MCP tools return responses that clients truncate or reject, so agents cannot use them.

Suggested fix

  • Add maxFindings (default for example 500, with truncated: true and the total count in the payload) and offset.
  • Add a summary mode that returns counts per rule and per file.
  • Drop the indentation in ok().
  • Run npm run generate:tools afterwards.

Acceptance criteria

  • By default, lint_project on a project with more findings than the limit returns at most the limit, plus totalFindings and a truncation flag.
  • Summary mode returns counts only.

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: performance|src/tools/result.ts|ok

主要语言
TypeScript
星标
0
派生
6
平均合并
1 天 21 小时
30 天内合并 PR
8

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/godot-correctness-mcp 的其他 Issue

查看 TMHSDigital/godot-correctness-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。