scene-node-path-missing false positive for $Path inside an inner class
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 84/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript
- 领域
- testing-qa
调研方向
Read src/scenes/node-paths.ts around lines 31–49 to see how pathUses walks class definitions, then review the related cases in test/node-paths.test.ts. Run npm run build && npm test to check the behavior; done means the inner-class $Label repro reports no warning while a top-level $Missing still does.
由索引模型根据 Issue 内容生成。
描述
Summary
scene-node-path-missing resolves $Path and get_node("...") literals inside inner classes (class Helper extends Node:) against the scene node the outer script is attached to. Those paths refer to the inner class instance's children, so the warning is a false positive.
Where
src/scenes/node-paths.ts:31-49(pathUseswalks the whole tree, includingclass_definitionbodies)
Steps to reproduce
- Create
main.tscnwith rootMain(scriptmain.gd,extends Node2D) and one child,Sprite. - In
main.gd:class Helper extends Node: func f() -> void: $Label.show() gdcorrect validate-scenes .reportsWARNING scene-node-path-missing Node path "Label" does not exist under this script's node.
Impact
Scripts that nest Node subclasses get spurious warnings, and --fail-on warning turns them into CI failures.
Suggested fix
In pathUses, do not descend into class_definition nodes. Only the top-level class body is attached to the scene node.
Acceptance criteria
- The repro reports nothing.
- A top-level
$Missingstill reports.
Getting started
- Relevant files:
src/scenes/node-paths.ts,test/node-paths.test.ts - How to run tests:
npm run build && npm test
Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: S. audit-key: bug|src/scenes/node-paths.ts|pathUses
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 6
- 平均合并
- 1 天 21 小时
- 30 天内合并 PR
- 8
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TMHSDigital/godot-correctness-mcp 的其他 Issue
-
enhancement good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 85/100
TMHSDigital/godot-correctness-mcp#123 ·
维护者通常 2 天内回复
-
dependencies good first issue severity: low
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/godot-correctness-mcp#116 ·
维护者通常 2 天内回复
-
bug good first issue severity: low
难度 2/5 1-3 小时 新手友好度 88/100
TMHSDigital/godot-correctness-mcp#107 ·
维护者通常 2 天内回复
-
bug good first issue severity: low
难度 2/5 1-3 小时 新手友好度 85/100
TMHSDigital/godot-correctness-mcp#106 ·
维护者通常 2 天内回复
-
bug good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 86/100
TMHSDigital/godot-correctness-mcp#104 ·
维护者通常 2 天内回复
查看 TMHSDigital/godot-correctness-mcp 的全部 Issue
相似的 Issue
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
难度 2/5 1-3 小时 新手友好度 76/100
openclaw/openclaw#203385 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
nwverse/persona#12800 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 80/100
维护者通常 1 天内回复
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
microsoft/playwright#44289 ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 半天 新手友好度 65/100
维护者通常 1 天内回复