lint_project and project_report return unbounded, pretty-printed findings

Offen
#129 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 2 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
58/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
api, performance

Rechercherichtung

Start by reading src/tools/lint.ts and src/tools/scenes.ts at the cited locations, then inspect src/tools/result.ts and the generated tool definitions. Compare the response shape with the acceptance criteria: lint_project should cap findings by default and include the total and truncation flag, while summary mode should return counts only. Run npm run generate:tools after changes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

help wanted performance severity: medium

Summary

lint_project and project_report return every finding in one pretty-printed text block, with no limit, paging or summary mode. On a realistic untyped project this is tens of megabytes, far beyond what an MCP client or LLM context can take.

Where

  • src/tools/lint.ts:65, src/tools/scenes.ts:100
  • src/tools/result.ts:9 (JSON.stringify(data, null, 2))

Details

A synthetic project with 3000 scripts produced 108k lint findings: 90k untyped-declaration, which is on by default, plus 6k stringly-nodepath. JSON output was 37.3 MB for lint and 39.5 MB for report. Even 10k findings is about 3.5 MB. The server-side cost (sort 264 ms, stringify 154 ms) is small; the problem is the size of the response.

Impact

On real projects that do not use static typing, the main MCP tools return responses that clients truncate or reject, so agents cannot use them.

Suggested fix

  • Add maxFindings (default for example 500, with truncated: true and the total count in the payload) and offset.
  • Add a summary mode that returns counts per rule and per file.
  • Drop the indentation in ok().
  • Run npm run generate:tools afterwards.

Acceptance criteria

  • By default, lint_project on a project with more findings than the limit returns at most the limit, plus totalFindings and a truncation flag.
  • Summary mode returns counts only.

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: performance|src/tools/result.ts|ok

Vorherrschende Sprache
TypeScript
Sterne
0
Forks
6
Ø Merge
1 T. 21 Std.
Gemergte PRs (30 T.)
8

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/godot-correctness-mcp

Alle Issues in TMHSDigital/godot-correctness-mcp

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.