lint_project and project_report return unbounded, pretty-printed findings

Aperta
#129 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
58/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
api, performance

Direzione di ricerca

Start by reading src/tools/lint.ts and src/tools/scenes.ts at the cited locations, then inspect src/tools/result.ts and the generated tool definitions. Compare the response shape with the acceptance criteria: lint_project should cap findings by default and include the total and truncation flag, while summary mode should return counts only. Run npm run generate:tools after changes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

help wanted performance severity: medium

Summary

lint_project and project_report return every finding in one pretty-printed text block, with no limit, paging or summary mode. On a realistic untyped project this is tens of megabytes, far beyond what an MCP client or LLM context can take.

Where

  • src/tools/lint.ts:65, src/tools/scenes.ts:100
  • src/tools/result.ts:9 (JSON.stringify(data, null, 2))

Details

A synthetic project with 3000 scripts produced 108k lint findings: 90k untyped-declaration, which is on by default, plus 6k stringly-nodepath. JSON output was 37.3 MB for lint and 39.5 MB for report. Even 10k findings is about 3.5 MB. The server-side cost (sort 264 ms, stringify 154 ms) is small; the problem is the size of the response.

Impact

On real projects that do not use static typing, the main MCP tools return responses that clients truncate or reject, so agents cannot use them.

Suggested fix

  • Add maxFindings (default for example 500, with truncated: true and the total count in the payload) and offset.
  • Add a summary mode that returns counts per rule and per file.
  • Drop the indentation in ok().
  • Run npm run generate:tools afterwards.

Acceptance criteria

  • By default, lint_project on a project with more findings than the limit returns at most the limit, plus totalFindings and a truncation flag.
  • Summary mode returns counts only.

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: performance|src/tools/result.ts|ok

Lingua principale
TypeScript
Stelle
0
Fork
6
Merge medio
1g 21h
PR unite (30g)
8

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/godot-correctness-mcp

Tutte le issue di TMHSDigital/godot-correctness-mcp

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.